public inbox for gnats-devel@sourceware.org
 help / color / mirror / Atom feed
From: Yngve Svendsen <yngve.svendsen@sun.com>
To: Lars Henriksen <Lars.Henriksen@netman.dk>
Cc: "'help-gnats@gnu.org'" <help-gnats@gnu.org>
Cc: Dieperink Alwin <alwin.dieperink@elca.ch>
Subject: Re: Categories containing "++" make gnatsweb crash
Date: Tue, 06 May 2003 09:31:00 -0000	[thread overview]
Message-ID: <5.2.1.0.0.20030506105539.03299ed8@ms-etro01-01.norway.sun.com> (raw)
In-Reply-To: <20030505174504.GA477164@teapot.netman.dk>

At 19:45 05.05.2003 +0200, Lars Henriksen wrote:
>I agree that assumptions about characters should be avoided and that the
>foreach-construction does this, but please lecture me: is perl-grep
>particularly expensive?.

I would assume grep is a bit more expensive than the foreach construct, 
since it builds and returns a list of matched values. However, the primary 
reason I changed over to a foreach construct is conceptual, I simply don't 
like using a function (grep) that returns a value which is then simply 
thrown away.

>I have another comment, though. If the field value isn't a known enumeration
>value, the value 'unknown' is inserted in the enumeration array and made
>the default value for display. But in my original code the insertion of
>'unknown' only happened if it wasn't already there (the second grep operation
>above). The reason is that 'unknown' may be a perfectly valid enumeration
>value (and if it is already there, we don't want to insert it a second time).

Good point. I will look at the patch and most likely apply it.

- Yngve 



_______________________________________________
Help-gnats mailing list
Help-gnats@gnu.org
http://mail.gnu.org/mailman/listinfo/help-gnats

  reply	other threads:[~2003-05-06  9:31 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-01-20 14:34 Dieperink Alwin
2003-04-29 19:47 ` Yngve Svendsen
2003-05-05 17:48   ` Lars Henriksen
2003-05-06  9:31     ` Yngve Svendsen [this message]
2003-05-06 21:13     ` Yngve Svendsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5.2.1.0.0.20030506105539.03299ed8@ms-etro01-01.norway.sun.com \
    --to=yngve.svendsen@sun.com \
    --cc=Lars.Henriksen@netman.dk \
    --cc=help-gnats@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).