From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <help-gnats-bounces+listarch-gnats-devel=sources.redhat.com@gnu.org>
Received: (qmail 25099 invoked from network); 11 Oct 2003 18:06:18 -0000
Received: from unknown (HELO monty-python.gnu.org) (199.232.76.173)
  by sources.redhat.com with SMTP; 11 Oct 2003 18:06:18 -0000
Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org)
	by monty-python.gnu.org with esmtp (Exim 4.24)
	id 1A8O6M-0003dP-6C
	for listarch-gnats-devel@sources.redhat.com; Sat, 11 Oct 2003 14:04:26 -0400
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1A8O6E-0003ce-3w
	for help-gnats@gnu.org; Sat, 11 Oct 2003 14:04:18 -0400
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1A8O5i-0003Z8-Gw
	for help-gnats@gnu.org; Sat, 11 Oct 2003 14:04:17 -0400
Received: from [207.17.136.150] (helo=merlot.juniper.net)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.24) id 1A8O5i-0003Z3-2z
	for help-gnats@gnu.org; Sat, 11 Oct 2003 14:03:46 -0400
Received: from juniper.net (garnet.juniper.net [172.17.28.17])
	by merlot.juniper.net (8.11.3/8.11.3) with ESMTP id h9BI3ij46618;
	Sat, 11 Oct 2003 11:03:44 -0700 (PDT) (envelope-from mdb@juniper.net)
To: Mel Hatzis <hatzis@juniper.net>
In-reply-to: Mail from Mel Hatzis <hatzis@juniper.net> 
	dated Fri, 10 Oct 2003 18:41:29 PDT
	<3F875FC9.4010404@juniper.net> 
References: <3F875FC9.4010404@juniper.net>
From: "Mark D. Baushke" <mdb@gnu.org>
X-Mailer: MH-E 7.4.2+cvs; nmh 1.0.4; GNU Emacs 21.1.1
X-Face: #8D_6URD2G%vC.hzU<dI&#Y9szHj$'mGtUq&d=rXy^L$-=G_-LmZ^5!Fszk:yXZp$k\nTF?
	8Up0!v/%1Q[(d?ES0mQW8dRCXi18gK)luJu)loHk,
	}4{Vi`yX?p?crF5o:LL{6#eiO:(E:YMxLXULB k|'a*EjN.B&L+[J!PhJ*aX0n:5/
Date: Sat, 11 Oct 2003 18:06:00 -0000
Message-ID: <77212.1065895424@juniper.net>
Cc: help-gnats@gnu.org
Subject: Re: using GNATS with xemacs 
X-BeenThere: help-gnats@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: General discussion about GNU GNATS  <help-gnats.gnu.org>
List-Archive: <http://mail.gnu.org/pipermail/help-gnats>
List-Post: <mailto:help-gnats@gnu.org>
List-Help: <mailto:help-gnats-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/help-gnats>,
	<mailto:help-gnats-request@gnu.org?subject=subscribe>
Sender: help-gnats-bounces+listarch-gnats-devel=sources.redhat.com@gnu.org
Errors-To: help-gnats-bounces+listarch-gnats-devel=sources.redhat.com@gnu.org
X-SW-Source: 2003-q4/txt/msg00008.txt.bz2

Mel Hatzis <hatzis@juniper.net> writes:

> Please review the attached patch which fixes a bug
> in the gnats.el file, allowing it to be used with
> xemacs.

Yes, XEmacs has a character type that is separate from an integer type
such that

     (eq 10 (char-to-int ?\n))

is t. 

As GNU Emacs does not have a char-to-int function, Mel's patch seems
reasonable to me to allow both GNU Emacs and XEmacs to use the same
gnats.el file.

I urge adoption of this patch.

	Thanks,
	-- Mark
     
> 
> Currently, if you attempt to use the gnats.el
> functionality with xemacs nothing works because
> every attempt to read the server response is
> failing.
> 
> --
> Mel Hatzis
> --- gnats.el~	6 Dec 2002 10:32:58 -0000	1.1.1.1
> +++ gnats.el	11 Oct 2003 01:09:57 -0000
> @@ -1197,7 +1197,7 @@ gnats-server-conn's `parsed-output' prop
>  parsed, the `output-complete' property is set."
>    (put gnats-server-conn 'curr-output
>         (concat (get gnats-server-conn 'curr-output) output))
> -  (if (eq 10 (string-to-char (substring output -1)))
> +  (if (eq ?\n (string-to-char (substring output -1)))
>        (progn
>  	(gnats-debug-string (get gnats-server-conn 'curr-output))
>  	(let ((our-output (get gnats-server-conn 'curr-output)))


_______________________________________________
Help-gnats mailing list
Help-gnats@gnu.org
http://mail.gnu.org/mailman/listinfo/help-gnats