From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15891 invoked from network); 14 May 2003 15:46:39 -0000 Received: from unknown (HELO monty-python.gnu.org) (199.232.76.173) by sources.redhat.com with SMTP; 14 May 2003 15:46:39 -0000 Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.10.13) id 19FyIL-0007oi-02 for listarch-gnats-devel@sources.redhat.com; Wed, 14 May 2003 11:35:53 -0400 Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.10.13) id 19FyGY-0007N0-00 for help-gnats@gnu.org; Wed, 14 May 2003 11:34:02 -0400 Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.10.13) id 19FyGU-0007Ks-00 for help-gnats@gnu.org; Wed, 14 May 2003 11:34:00 -0400 Received: from [193.72.144.2] (helo=mail.elca.ch) by monty-python.gnu.org with esmtp (Exim 4.10.13) id 19FyGT-0007BB-00 for help-gnats@gnu.org; Wed, 14 May 2003 11:33:58 -0400 Received: from exchange.elca.ch (unverified) by mail.elca.ch ; Wed, 14 May 2003 17:33:47 +0200 Received: by exchange.elca.ch with Internet Mail Service (5.5.2653.19) id ; Wed, 14 May 2003 17:33:57 +0200 Message-ID: From: Dieperink Alwin To: 'Yngve Svendsen' Date: Wed, 14 May 2003 15:46:00 -0000 MIME-Version: 1.0 X-Mailer: Internet Mail Service (5.5.2653.19) Content-Type: text/plain; charset="ISO-8859-1" cc: "'help-gnats@gnu.org'" Subject: RE: Patch for "send email to interested parties" X-BeenThere: help-gnats@gnu.org X-Mailman-Version: 2.1b5 Precedence: list List-Id: General discussion about GNU GNATS List-Help: List-Post: List-Subscribe: , List-Archive: Sender: help-gnats-bounces+listarch-gnats-devel=sources.redhat.com@gnu.org Errors-To: help-gnats-bounces+listarch-gnats-devel=sources.redhat.com@gnu.org X-SW-Source: 2003-q2/txt/msg00050.txt.bz2 Hi Yngve, Since this patch had been applied, I upgraded to MSIE 6.0. And guess... Microsoft has changed the way they handle URLs... :-( HTTP_USER_AGENT now gives: "Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.0)" So I prepared a new version of the test, which should only have a changed behaviour for the new browser: # Netscape Navigator up to and including 4.x should get the URL in # the body encoded only once -- and so should Opera # and so should MSIE > 6.0 unless ( (($ENV{'HTTP_USER_AGENT'} =~ "Mozilla\/(.)(.*)") && ($1 < 5) && ($2 !~ "compatible")) || $ENV{'HTTP_USER_AGENT'} =~ "Opera\/" || ($ENV{'HTTP_USER_AGENT'} =~ ".* MSIE (.).*" && ($1 >= 6)) ) { $body = $q->escape($body); } Regards -- Alwin -----Original Message----- From: Yngve Svendsen [mailto:yngve.svendsen@sun.com] Sent: samedi, 12. octobre 2002 01:06 To: Dieperink Alwin; 'help-gnats@gnu.org' Subject: Re: Patch for "send email to interested parties" At 20:19 11.10.2002 +0200, Yngve Svendsen wrote: >Netscape and IE handle URL quoting in different ways, and the patch would >not work for Netscape browsers. I've spent a considerable amount of time >devising a quoting mechanism that would work for both browsers but never >got round to finishing it. Thanks for getting me thinking about this again. I came up with the following, which seems to work OK on the (many) browsers I've tested it on. Testing has revealed that Netscape Navigator <= 4.x is the odd one out here, since that is the only series of browsers which works with the old way Gnatsweb quoted these URLs. This patch turns the situation around, treating these browsers as special cases. Still, some 4.x releases have bugs in their handling of this kind of URL, making a workaround for _all_ Netscape 4.x browsers impossible. This patch should take care of most of them, though, while solving the problem completely for non-Netscape browsers. This has been committed to the v4 branch of Gnatsweb. - Yngve Index: gnatsweb.pl =================================================================== RCS file: /cvsroot/gnatsweb/gnatsweb/gnatsweb.pl,v retrieving revision 1.102 diff -u -p -r1.102 gnatsweb.pl --- gnatsweb.pl 11 Oct 2002 21:09:36 -0000 1.102 +++ gnatsweb.pl 11 Oct 2002 22:54:53 -0000 @@ -1320,6 +1320,14 @@ sub get_mailto_link my $subject = $q->escape("Re: $fields{$CATEGORY_FIELD}/$pr: $fields{$SYNOPSIS_FIELD}"); my $body = $q->escape(get_viewpr_url($pr)); + # Netscape Navigator up to and including 4.x should get the URL in + # the body encoded only once + unless ( ($ENV{'HTTP_USER_AGENT'} =~ "Mozilla\/(.)(.*)") && ($1 < 5) + && ($2 !=~ "compatible") ) + { + $body = $q->escape($body); + } + my $reply = "" . "send email to interested parties\n"; _______________________________________________ Help-gnats mailing list Help-gnats@gnu.org http://mail.gnu.org/mailman/listinfo/help-gnats