gnatsweb and cookies w/o Javasript (fwd)

[Gerald Pfeifer <pfeifer@dbai.tuwien.ac.at>]

I have not received any feedback for the patch included below, so I'm
trying again, in the hope that this is the right address where someone
will have a look.

Gerald

---------- Forwarded message ----------
From: Gerald Pfeifer <pfeifer@dbai.tuwien.ac.at>
To: Kenneth H. Cox <kenstir@abraham.senteinc.com>
Cc: bug-gnats@gnu.org
Date: Tue, 4 Jul 2000 12:04:28 +0200 (CEST)
Subject: gnatsweb and cookies w/o Javasript

Folks (including myself but just today we got a real bug report at
the GCC project concerning this) often are caught by gnatsweb requiring
cookies but not specifying that to the user.

I realized that there is now Javascript code to do exactly that, but
more often than not, folks with cookies disabled (or no support for
cookies in the browser) do not have Javascript either!

Please consider the patch below, which I already installed at the
gcc.gnu.org (and thus the sources.redhat.com) GNATS site.

(This patch also avoids the phrase "pressing the button" which does
not apply to all users.)

Gerald

Index: gnatsweb.pl
===================================================================
RCS file: /cvs/gcc/wwwdocs/cgi-bin/gnatsweb.pl,v
retrieving revision 1.7
retrieving revision 1.10
diff -c -3 -p -r1.7 -r1.10
*** gnatsweb.pl	2000/05/11 07:00:34	1.7
--- gnatsweb.pl	2000/07/04 09:03:52	1.10
*************** delCookie("gnatsweb-test-cookie");
*** 2894,2901 ****
  if (val == null) {
      document.write("<h2>Warning: your browser is not accepting cookies</h2>"
          + "Gnatsweb requires cookies to keep track of your login and other "
!         + "information.  Please enable cookies before pressing the "
!         + "<tt>login</tt> button.");
  }
  
  //-->
--- 2894,2900 ----
  if (val == null) {
      document.write("<h2>Warning: your browser is not accepting cookies</h2>"
          + "Gnatsweb requires cookies to keep track of your login and other "
!         + "information.  Please enable cookies before logging in.");
  }
  
  //-->
*************** sub login_page
*** 2929,2935 ****
    # are not really needed; use the username as the default.
    my $def_password = $db_prefs{'password'} || $ENV{'REMOTE_USER'};
    print $q->start_form(),
!         "<p>Use username '<b>guest</b>' and password '<b>guest</b>' for read-only and bug reporting access.",
          "<table>",
          "<tr><td>User Name:<td>",
          $q->textfield(-name=>'user',
--- 2928,2938 ----
    # are not really needed; use the username as the default.
    my $def_password = $db_prefs{'password'} || $ENV{'REMOTE_USER'};
    print $q->start_form(),
!         "<p>Use username '<b>guest</b>' and password '<b>guest</b>' for".
!         " read-only and bug reporting access.",
!         " Unfortunately, GNATSweb requires cookies to keep track".
!         " of your login and other information.  Please enable cookies".
!         " before logging in.",
          "<table>",
          "<tr><td>User Name:<td>",
          $q->textfield(-name=>'user',