Re: PR 375 - Point 1

[Gerald Pfeifer <pfeifer@dbai.tuwien.ac.at>]

On Wed, 10 Jan 2001, Mark Kuchel wrote:
>> * The login page makes no mention of needing to have cookies enabled;
> The problem here under lynx is that it doesn't use javascript.  For
> lynx and other browsers in that class, adding in a simple
> <noscript>...</noscript> section telling them that they need cookies
> turned on to work.  This also works for browsers such as netscape and
> mozilla when you turn javascript off in them.
> [...]
> The patch was tested with netscape 4.75, mozilla M18, lynx 2.8.4 and
> konqueror from kdebase 2.0.6 from mandrake.

Thanks!

I had fixed this in a somewhat different way for the modified version we
used for gcc.gnu.org, but I agree that using <noscript> is a much better
idea, so I merged our two patches and installed the following into the
GNATS repository (and on gcc.gnu.org as well, so that we have more
extensive testing).

Sorry for the delay, but now I'm nearly done with the gnatsweb patch
backlog. Send more patches! :-)

Gerald


2001-02-03  Mark Kuchel <mark@kuchel.net>
            Gerald Pfeifer  <pfeifer@dbai.tuwien.ac.at>

	* gnatsweb.pl (login_page_javascript): Properly warn about cookies
	being required, both if Javascript is enabled and if it is disabled.

Index: gnatsweb.pl
===================================================================
RCS file: /cvs/gnats/gnats/contrib/gnatsweb/gnatsweb.pl,v
retrieving revision 2.21
diff -u -3 -p -r2.21 gnatsweb.pl
--- gnatsweb.pl	2001/01/22 15:29:03	2.21
+++ gnatsweb.pl	2001/02/03 12:41:53
@@ -2815,13 +2815,21 @@ val = getCookie("gnatsweb-test-cookie");
 delCookie("gnatsweb-test-cookie");
 if (val == null) {
     document.write("<h2>Warning: your browser is not accepting cookies</h2>"
-        + "Gnatsweb requires cookies to keep track of your login and other "
-        + "information.  Please enable cookies before pressing the "
-        + "<tt>login</tt> button.");
+        ."<p>Unfortunately, Gnatsweb requires cookies to keep track of your "
+        ."login and other information. "
+        ."Please enable cookies before logging in.</p>");
 }

 //-->
 </SCRIPT>
+<noscript>
+<p>(Due to the fact that your browser does not support Javascript,
+there is no way of telling whether it can accept cookies.)
+
+Unfortunately, Gnatsweb requires cookies to keep track of your"
+login and other information.
+Please enable cookies before logging in.</p>
+</noscript>
   };
 }