From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <help-gnats-admin@gnu.org>
Received: (qmail 22360 invoked from network); 6 Jan 2002 16:53:53 -0000
Received: from unknown (HELO fencepost.gnu.org) (199.232.76.164)
  by sources.redhat.com with SMTP; 6 Jan 2002 16:53:53 -0000
Received: from localhost ([127.0.0.1] helo=fencepost.gnu.org)
	by fencepost.gnu.org with esmtp (Exim 3.33 #1 (Debian))
	id 16NGSq-0001Zs-00; Sun, 06 Jan 2002 11:48:04 -0500
Received: from vexpert.dbai.tuwien.ac.at ([128.130.111.12])
	by fencepost.gnu.org with esmtp (Exim 3.33 #1 (Debian))
	id 16NGR7-0001Ww-00
	for <help-gnats@gnu.org>; Sun, 06 Jan 2002 11:46:17 -0500
Received: from [128.130.111.23] (pulcherrima [128.130.111.23])
	by vexpert.dbai.tuwien.ac.at (8.11.6/8.11.6) with ESMTP id g06GkFW25847
	for <help-gnats@gnu.org>; Sun, 6 Jan 2002 17:46:16 +0100 (MET)
From: Gerald Pfeifer <pfeifer@dbai.tuwien.ac.at>
To: help-gnats@gnu.org
Subject: Re: PATCH: gnatsweb.pl
In-Reply-To: <Pine.BSF.4.43.0112182214090.45594-100000@pulcherrima.dbai.tuwien.ac.at>
Message-ID: <Pine.BSF.4.43.0201061745010.86761-100000@pulcherrima.dbai.tuwien.ac.at>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: help-gnats-admin@gnu.org
Errors-To: help-gnats-admin@gnu.org
X-BeenThere: help-gnats@gnu.org
X-Mailman-Version: 2.0.5
Precedence: bulk
List-Help: <mailto:help-gnats-request@gnu.org?subject=help>
List-Post: <mailto:help-gnats@gnu.org>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/help-gnats>,
	<mailto:help-gnats-request@gnu.org?subject=subscribe>
List-Id: General discussion about GNU GNATS <help-gnats.gnu.org>
List-Archive: <http://mail.gnu.org/pipermail/help-gnats/>
Date: Sun, 06 Jan 2002 08:53:00 -0000
X-SW-Source: 2002-q1/txt/msg00015.txt.bz2

I committed the gnatsweb 2.99 version of this patch. Yngve, you might
want to apply the first version to the 2.9.x-branch.

Gerald

On Tue, 18 Dec 2001, Gerald Pfeifer wrote:
> GNATS folks (Yngve): Without this patch, gnatsweb mixes classic HTML color
> tags and CSS with the result that (for example on Netscape 4.7) users with
> style sheets disabled easily get white text on white background.
>
> The first patch is for gnatsweb 2.9.3 and tested, the second for current
> development sources 2.99.2 and untested. (If you agree, would you mind
> applying the one against 2.9.3 for me? I can take care of 2.99.2.)
>
> Gerald
>
> 2001-12-18  Gerald Pfeifer  <pfeifer@dbai.tuwien.ac.at>
>
>         * gnatsweb.pl (page_start_html): Do not mix classic HTML color
>         tags (BGCOLOR) and CSS.
>
> Index: gnatsweb.pl
> ===================================================================
> RCS file: /cvs/gcc/wwwdocs/cgi-bin/gnatsweb.pl,v
> retrieving revision 1.45
> retrieving revision 1.49
> diff -u -3 -p -r1.45 -r1.49
> --- gnatsweb.pl	2001/12/15 09:57:40	1.45
> +++ gnatsweb.pl	2001/12/18 21:11:00	1.49
> @@ -2501,7 +2501,7 @@ EOF
>    $createurl = get_createpr_url(0,1);
>
>    $row = qq(<TR>\n<TD><TABLE BORDER="0" CELLSPACING="0" CELLPADDING="3" WIDTH="100%">);
> -  $row .= qq(<TR BGCOLOR="$site_banner_background">\n<TD ALIGN="LEFT">);
> +  $row .= qq(<TR STYLE="background-color: $site_banner_background">\n<TD ALIGN="LEFT">);
>    $row .= qq(<SPAN STYLE="$bannerstyle $banner_fontsize1">$global_prefs{'database'}&nbsp;&nbsp;</SPAN>)
>          if $global_prefs{'database'};
>    $row .= qq(<SPAN STYLE="$bannerstyle $banner_fontsize2">User: $db_prefs{'user'}&nbsp;&nbsp;</SPAN>)
>
> Index: gnatsweb.pl
> ===================================================================
> RCS file: /cvsroot/gnatsweb/gnatsweb/gnatsweb.pl,v
> retrieving revision 1.87
> diff -u -3 -p -r1.87 gnatsweb.pl
> --- gnatsweb.pl	12 Dec 2001 14:10:56 -0000	1.87
> +++ gnatsweb.pl	18 Dec 2001 21:20:30 -0000
> @@ -3077,7 +3077,7 @@ EOF
>    my $createurl = get_pr_url('create', 0, 1);
>
>    $row = qq(<tr>\n<td><table border="0" cellspacing="0" cellpadding="3" width="100%">);
> -  $row .= qq(<tr bgcolor="$site_banner_background">\n<td align="left">);
> +  $row .= qq(<tr style="background-color: $site_banner_background">\n<td align="left">);
>    $row .= qq(<span style="$bannerstyle $banner_fontsize1">$global_prefs{'database'}&nbsp;&nbsp;</span>)
>                   if $global_prefs{'database'};
>    $row .= qq(<span style="$bannerstyle $banner_fontsize2">User: $db_prefs{'user'}&nbsp;&nbsp;</span>)


_______________________________________________
Help-gnats mailing list
Help-gnats@gnu.org
http://mail.gnu.org/mailman/listinfo/help-gnats