public inbox for gnats-prs@sourceware.org
help / color / mirror / Atom feed
From: bhoule@airfiber.com
To: gnats-gnats@sourceware.cygnus.com
Subject: gnats/168: ORIGINATOR used only by send-pr
Date: Tue, 20 Mar 2001 21:44:00 -0000	[thread overview]
Message-ID: <20010321053403.26000.qmail@sourceware.cygnus.com> (raw)

>Number:         168
>Category:       gnats
>Synopsis:       ORIGINATOR used only by send-pr
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    unassigned
>State:          open
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Tue Mar 20 21:44:00 PST 2001
>Closed-Date:
>Last-Modified:
>Originator:     Bill Houle
>Release:        3.113
>Organization:
>Environment:
Solaris
>Description:
Since the "Reporter's email" is part of the envelope rather than the PR, it is not searchable. On the other hand, the "Originator" *is* searchable, but it only gets filled out by send-pr via the NAME env-var.

Enhancement: populate the Originator field with the email address of the sender when submitted via email (file-pr).
>How-To-Repeat:
Q.E.D
>Fix:
*** file-pr.c-orig      Tue Mar 20 19:45:58 2001
--- file-pr.c   Tue Mar 20 20:49:44 2001
***************
*** 51,57 ****
    char *subject = NULL, *synopsis = NULL;
    char *p;
    char message[STR_MAX];
!   char *from_address;
  
    mode_t mode;
    struct stat sbuf;
--- 51,57 ----
    char *subject = NULL, *synopsis = NULL;
    char *p;
    char message[STR_MAX];
!   char *from_address = NULL, *originator = NULL;
  
    mode_t mode;
    struct stat sbuf;
***************
*** 187,192 ****
--- 187,205 ----
        set_field (SYNOPSIS, synopsis);
      }
  
+   /* Set originator to be email address.  */
+   from_address = header_value (FROM);
+   if (*from_address != '\0')
+     {
+       /* The originator shouldn't have a newline at the end.  */
+       char *l;
+       originator = (char *) strdup (from_address);
+       l = (char *) strrchr (originator, '\n');
+       if (l != NULL)
+       *l = '\0';
+       set_field (ORIGINATOR, originator);
+   }
+ 
    /* Set arrival date and time of response.  */
    seconds = time ((time_t) 0);
    strftime (arrival_time, GNATS_TIME_LENGTH, "%a %b %d %H:%M:%S %Z %Y",
>Release-Note:
>Audit-Trail:
>Unformatted:


                 reply	other threads:[~2001-03-20 21:44 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20010321053403.26000.qmail@sourceware.cygnus.com \
    --to=bhoule@airfiber.com \
    --cc=gnats-gnats@sourceware.cygnus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).