Re: gnats/200: gnatsd.h includes <crypt.h> for crypt(3) rather than <unistd.h>

Re: gnats/200: gnatsd.h includes <crypt.h> for crypt(3) rather than <unistd.h>

[Milan Zamazal]

The following reply was made to PR gnats/200; it has been noted by GNATS.

From: Milan Zamazal <pdm@zamazal.org>
To: soren@wheel.dk
Cc: gnats-gnats@sourceware.cygnus.com
Subject: Re: gnats/200: gnatsd.h includes <crypt.h> for crypt(3) rather than <unistd.h>
Date: 10 Jun 2001 17:25:41 +0200

 >>>>> "s" == soren  <soren@wheel.dk> writes:
 
     s> <crypt.h> is a little outdated, and modern systems specify
     s> <unistd.h> for crypt(3). E.g. *BSD don't have <crypt.h>.
 
 [...]
 
     >> Fix:
     s> Index: gnatsd.c
     s> ===================================================================
     s> RCS file: /cvs/gnats/gnats/gnats/gnatsd.c,v
     s> retrieving revision 1.40
     s> diff -u -w -r1.40 gnatsd.c
     s> --- gnatsd.c    2001/04/15 18:11:51     1.40
     s> +++ gnatsd.c    2001/05/31 15:26:03
     s> @@ -24,9 +24,7 @@
     s>  #include "gnatsd.h"
     s>  #include "query.h"
  
     s> -#ifdef HAVE_LIBCRYPT
     s> -#include <crypt.h>
     s> -#endif
     s> +#include <unistd.h>
  
     s>  #if defined (__svr4__) && defined (__sun__)
     s>  #undef SIG_IGN
 
 Well, GNATS should run on less modern systems too, so I now include
 crypt.h only if available.  That should fix the build problems on
 systems having crypt in unistd.h.
 
 Thanks for the report.
 
 Regards,
 
 Milan Zamazal
 
 -- 
 http://www.zamazal.org

Re: gnats/200: gnatsd.h includes <crypt.h> for crypt(3) rather than <unistd.h>

[pdm]

Synopsis: gnatsd.h includes <crypt.h> for crypt(3) rather than <unistd.h>

State-Changed-From-To: feedback->closed
State-Changed-By: pdm
State-Changed-When: Mon Jul 30 12:07:00 2001
State-Changed-Why:
    There were no objections.

http://sources.redhat.com/cgi-bin/gnatsweb.pl?cmd=view&pr=200&database=gnats

gnats/200: gnatsd.h includes <crypt.h> for crypt(3) rather than <unistd.h>

[soren]

>Number:         200
>Category:       gnats
>Synopsis:       gnatsd.h includes <crypt.h> for crypt(3) rather than <unistd.h>
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    unassigned
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu May 31 08:34:00 PDT 2001
>Closed-Date:
>Last-Modified:
>Originator:     Soren S. Jorvang
>Release:        anoncvs as of today
>Organization:
>Environment:
NetBSD-current as of today
>Description:
<crypt.h> is a little outdated, and modern systems specify
<unistd.h> for crypt(3). E.g. *BSD don't have <crypt.h>.
>How-To-Repeat:
Try to build GNATS 4 on NetBSD.
>Fix:
Index: gnatsd.c
===================================================================
RCS file: /cvs/gnats/gnats/gnats/gnatsd.c,v
retrieving revision 1.40
diff -u -w -r1.40 gnatsd.c
--- gnatsd.c    2001/04/15 18:11:51     1.40
+++ gnatsd.c    2001/05/31 15:26:03
@@ -24,9 +24,7 @@
 #include "gnatsd.h"
 #include "query.h"
 
-#ifdef HAVE_LIBCRYPT
-#include <crypt.h>
-#endif
+#include <unistd.h>
 
 #if defined (__svr4__) && defined (__sun__)
 #undef SIG_IGN
>Release-Note:
>Audit-Trail:
>Unformatted: