public inbox for gnats-prs@sourceware.org
help / color / mirror / Atom feed
* gnatsweb/386: Gnatsweb must check text with regexp before submitting new PR
@ 2002-05-26 7:27 Lars.Henriksen
2002-05-27 5:15 ` Yngve Svendsen
0 siblings, 1 reply; 2+ messages in thread
From: Lars.Henriksen @ 2002-05-26 7:27 UTC (permalink / raw)
To: pdm-gnats, gnats-prs, bug-gnats
>Number: 386
>Category: gnatsweb
>Synopsis: Gnatsweb must check text with regexp before submitting new PR
>Confidential: no
>Severity: critical
>Priority: high
>Responsible: unassigned
>State: open
>Class: sw-bug
>Submitter-Id: net
>Arrival-Date: Sun May 26 10:24:33 -0400 2002
>Originator: Lars.Henriksen@netman.dk
>Release: 3.99.3
>Organization:
>Environment:
>Description:
Gnatsweb submits a new PR to gnatsd with the SUBM command.
SUBM will accept almost anything as contents of aPR, and it
certainly doesn't check field contents. This is to some
extent done by Gnatsweb for enumerated-in-file fields, but
not for text fields with matching regexps.
This implies that you can create a PR that will be rejected
with an invalid text field the first time you edit it, even
though you didn't change the text field (but something else).
Fix included (that also removes a superfluous newline).
>How-To-Repeat:
>Fix:
--- gnatsweb.pl-3.99.3 Sun May 26 15:39:55 2002
+++ gnatsweb.pl.fix Sun May 26 16:06:06 2002
@@ -1222,8 +1222,11 @@
return;
}
+ client_cmd ("chek initial");
+ client_cmd("$text.");
+ return if ($client_would_have_exited);
client_cmd ("subm");
- client_cmd("$text\n.");
+ client_cmd("$text.");
my $return_url = $q->param('return_url') || get_script_name();
my $refresh = 5;
>Unformatted:
_______________________________________________
Gnats-prs mailing list
Gnats-prs@gnu.org
http://mail.gnu.org/mailman/listinfo/gnats-prs
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: gnatsweb/386: Gnatsweb must check text with regexp before submitting new PR
2002-05-26 7:27 gnatsweb/386: Gnatsweb must check text with regexp before submitting new PR Lars.Henriksen
@ 2002-05-27 5:15 ` Yngve Svendsen
0 siblings, 0 replies; 2+ messages in thread
From: Yngve Svendsen @ 2002-05-27 5:15 UTC (permalink / raw)
To: Lars.Henriksen, pdm-gnats, gnats-prs, bug-gnats
At 10:24 26.05.2002 -0400, Lars.Henriksen@netman.dk wrote:
>Fix included (that also removes a superfluous newline).
Thanks! I am putting this in the queue of things that will be applied when
I get Gnatsweb development going again, hopefully not too late in the summer.
- Yngve
_______________________________________________
Gnats-prs mailing list
Gnats-prs@gnu.org
http://mail.gnu.org/mailman/listinfo/gnats-prs
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2002-05-27 12:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2002-05-26 7:27 gnatsweb/386: Gnatsweb must check text with regexp before submitting new PR Lars.Henriksen
2002-05-27 5:15 ` Yngve Svendsen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).