From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gnats-prs-admin@gnu.org>
Received: (qmail 2206 invoked from network); 3 Jan 2002 04:39:59 -0000
Received: from unknown (HELO fencepost.gnu.org) (199.232.76.164)
  by sources.redhat.com with SMTP; 3 Jan 2002 04:39:59 -0000
Received: from localhost ([127.0.0.1] helo=fencepost.gnu.org)
	by fencepost.gnu.org with esmtp (Exim 3.22 #1 (Debian))
	id 16Lzeh-0000MQ-00; Wed, 02 Jan 2002 23:39:03 -0500
Received: from gnats by fencepost.gnu.org with local (Exim 3.22 #1 (Debian))
	id 16Lzc1-00008x-00; Wed, 02 Jan 2002 23:36:17 -0500
From: forrest@mibsoftware.com
To: pdm-gnats@zamazal.org,gnats-prs@gnu.org,bug-gnats@gnu.org
Reply-To: forrest@mibsoftware.com
Subject: gnats/317: bad decl of tmpdir in  temporary_directory() in misc.c
Message-Id: <E16Lzc1-00008x-00@fencepost.gnu.org>
Sender: gnats-prs-admin@gnu.org
Errors-To: gnats-prs-admin@gnu.org
X-BeenThere: gnats-prs@gnu.org
X-Mailman-Version: 2.0.5
Precedence: bulk
List-Help: <mailto:gnats-prs-request@gnu.org?subject=help>
List-Post: <mailto:gnats-prs@gnu.org>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/gnats-prs>,
	<mailto:gnats-prs-request@gnu.org?subject=subscribe>
List-Id: Copies of bug tracking system messages <gnats-prs.gnu.org>
List-Archive: <http://mail.gnu.org/pipermail/gnats-prs/>
Date: Wed, 02 Jan 2002 20:39:00 -0000
X-SW-Source: 2002-q1/txt/msg00004.txt.bz2

>Number:         317
>Category:       gnats
>Synopsis:       bad decl of tmpdir in  temporary_directory() in misc.c
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    unassigned
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Jan 02 23:36:17 -0500 2002
>Originator:     Forrest Cavalier
>Release:        
>Organization:
Mib Software
>Environment:
GNATS 4.0 from cvs.
On WIN32
>Description:
In misc.c, bad decl of tmpdir
  char tmpdir = *getenv ("TMPDIR");
  if (tmpdir == NULL)

>How-To-Repeat:
Generates a warning, but probably incorrect
code too.  Could segfault since getenv() could
return NULL, leading to *(NULL).
>Fix:
--- gnats/gnats/gnats/misc.c	Thu Dec 06 17:25:21 2001
+++ modified/gnats/misc.c	Wed Jan 02 23:29:29 2002
@@ -499,7 +499,7 @@
 #ifdef P_tmpdir
   return P_tmpdir;
 #else
-  char tmpdir = *getenv ("TMPDIR");
+  char *tmpdir = getenv ("TMPDIR");
   if (tmpdir == NULL)
     {
       tmpdir = "/tmp";
>Unformatted:
 

_______________________________________________
Gnats-prs mailing list
Gnats-prs@gnu.org
http://mail.gnu.org/mailman/listinfo/gnats-prs