gnats/319: basename() requires <libgen.h> on NetBSD 1.5.2, but it is not included.

gnats/319: basename() requires <libgen.h> on NetBSD 1.5.2, but it is not included.

[demizu]

>Number:         319
>Category:       gnats
>Synopsis:       basename() requires <libgen.h> on NetBSD 1.5.2, but it is not included.
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    unassigned
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Jan 04 04:32:58 -0500 2002
>Originator:     Noritoshi Demizu
>Release:        gnats 4.0 beta 1 (CVS)
>Organization:

>Environment:
NetBSD 1.5.2
>Description:
On NetBSD 1.5.2, gnats/query-pr.c cannot be compiled because basename() requires <libgen.h>.
>How-To-Repeat:
make gnats 4.0 beta on NetBSD 1.5.2.
>Fix:
Here is a sample fix.
--- gnats/gnats.h-ORG	Mon Dec 24 05:21:33 2001
+++ gnats/gnats.h	Mon Dec 31 13:37:44 2001
@@ -87,6 +87,10 @@
 #include <sys/file.h>
 #endif
 
+#ifdef HAVE_LIBGEN_H
+#include <libgen.h>
+#endif /* HAVE_LIBGEN_H */
+
 #ifndef alloca
 /* Make alloca work the best possible way.  */
 #ifdef __GNUC__
--- gnats/configure.in-ORG	Mon Dec 24 05:21:33 2001
+++ gnats/configure.in	Mon Dec 31 13:36:10 2001
@@ -88,7 +88,7 @@
 AC_CHECK_LIB(crypt, crypt)
 
 AC_STDC_HEADERS
-AC_CHECK_HEADERS(string.h fcntl.h limits.h syslog.h memory.h netdb.h unistd.h crypt.h sys/select.h machine/endian.h)
+AC_CHECK_HEADERS(string.h fcntl.h limits.h syslog.h memory.h netdb.h unistd.h crypt.h sys/select.h machine/endian.h libgen.h)
 AC_EGREP_HEADER(\<unsetenv\>, stdlib.h,
   AC_DEFINE(HAVE_DECL_UNSETENV,1,[Whether unsetenv is present in headers.]),
   AC_DEFINE(HAVE_DECL_UNSETENV,0,[Whether unsetenv is present in headers.]))
--- gnats/autoconf.h.in-ORG	Mon Dec 24 05:21:33 2001
+++ gnats/autoconf.h.in	Mon Dec 31 13:40:48 2001
@@ -111,6 +111,9 @@
 /* Define if you have the <unistd.h> header file.  */
 #undef HAVE_UNISTD_H
 
+/* Define if you have the <libgen.h> header file.  */
+#undef HAVE_LIBGEN_H
+
 /* Define if you have the crypt library (-lcrypt).  */
 #undef HAVE_LIBCRYPT
 
>Unformatted:
 

_______________________________________________
Gnats-prs mailing list
Gnats-prs@gnu.org
http://mail.gnu.org/mailman/listinfo/gnats-prs

Re: gnats/319: basename() requires <libgen.h> on NetBSD 1.5.2, but it is not included.

[Milan Zamazal]

Thanks for the report and patch, I'll apply it.

BTW, autoconf.h.in is generated, the right way to add something there is
to add it to configure.in and run autoconf (to generate configure) and
autoheader (to generate autoconf.h.in).

Regards,

Milan Zamazal

-- 
And why?

_______________________________________________
Gnats-prs mailing list
Gnats-prs@gnu.org
http://mail.gnu.org/mailman/listinfo/gnats-prs

Re: gnats/319: basename() requires <libgen.h> on NetBSD 1.5.2, but it is not included.

[Noritoshi Demizu]

Milan Zamazal,

Thank you very much for fixing the problem gnats/319.

I just retrieved the newest version as of Jan 7 14:05 GMT 2002.
The update includes your fix to gnats/319.  And I could successfully
make gnats 4.x on NetBSD 1.5.2 without my patch.  Thank you very much.

 > BTW, autoconf.h.in is generated, the right way to add something there is
 > to add it to configure.in and run autoconf (to generate configure) and
 > autoheader (to generate autoconf.h.in).

Thank you.  As obvious, I am new to auto-tools.  Thank you very much
for fixing my fix. :-)

Regards,
Noritoshi Demizu

ps. I have visited Praha in June, 1994.  It was very very beautiful city.
    I wish I will visit Praha in summer again.

_______________________________________________
Gnats-prs mailing list
Gnats-prs@gnu.org
http://mail.gnu.org/mailman/listinfo/gnats-prs