public inbox for gnats-prs@sourceware.org help / color / mirror / Atom feed
From: Lars.Henriksen@netman.dk To: pdm-gnats@zamazal.org,gnats-prs@gnu.org,bug-gnats@gnu.org Subject: gnatsweb/386: Gnatsweb must check text with regexp before submitting new PR Date: Sun, 26 May 2002 07:27:00 -0000 [thread overview] Message-ID: <E17Bywj-0006K1-00@fencepost.gnu.org> (raw) >Number: 386 >Category: gnatsweb >Synopsis: Gnatsweb must check text with regexp before submitting new PR >Confidential: no >Severity: critical >Priority: high >Responsible: unassigned >State: open >Class: sw-bug >Submitter-Id: net >Arrival-Date: Sun May 26 10:24:33 -0400 2002 >Originator: Lars.Henriksen@netman.dk >Release: 3.99.3 >Organization: >Environment: >Description: Gnatsweb submits a new PR to gnatsd with the SUBM command. SUBM will accept almost anything as contents of aPR, and it certainly doesn't check field contents. This is to some extent done by Gnatsweb for enumerated-in-file fields, but not for text fields with matching regexps. This implies that you can create a PR that will be rejected with an invalid text field the first time you edit it, even though you didn't change the text field (but something else). Fix included (that also removes a superfluous newline). >How-To-Repeat: >Fix: --- gnatsweb.pl-3.99.3 Sun May 26 15:39:55 2002 +++ gnatsweb.pl.fix Sun May 26 16:06:06 2002 @@ -1222,8 +1222,11 @@ return; } + client_cmd ("chek initial"); + client_cmd("$text."); + return if ($client_would_have_exited); client_cmd ("subm"); - client_cmd("$text\n."); + client_cmd("$text."); my $return_url = $q->param('return_url') || get_script_name(); my $refresh = 5; >Unformatted: _______________________________________________ Gnats-prs mailing list Gnats-prs@gnu.org http://mail.gnu.org/mailman/listinfo/gnats-prs
next reply other threads:[~2002-05-26 14:27 UTC|newest] Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top 2002-05-26 7:27 Lars.Henriksen [this message] 2002-05-27 5:15 ` Yngve Svendsen
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=E17Bywj-0006K1-00@fencepost.gnu.org \ --to=lars.henriksen@netman.dk \ --cc=bug-gnats@gnu.org \ --cc=gnats-prs@gnu.org \ --cc=pdm-gnats@zamazal.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).