From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22905 invoked from network); 3 Jun 2002 23:21:38 -0000 Received: from unknown (HELO fencepost.gnu.org) (199.232.76.164) by sources.redhat.com with SMTP; 3 Jun 2002 23:21:38 -0000 Received: from localhost ([127.0.0.1] helo=fencepost.gnu.org) by fencepost.gnu.org with esmtp (Exim 3.34 #1 (Debian)) id 17F15e-0008Qa-00; Mon, 03 Jun 2002 19:18:18 -0400 Received: from gnats by fencepost.gnu.org with local (Exim 3.34 #1 (Debian)) id 17F14K-0008O7-00; Mon, 03 Jun 2002 19:16:56 -0400 From: kmcfarland@starentnetworks.com To: pdm-gnats@zamazal.org,gnats-prs@gnu.org,bug-gnats@gnu.org Reply-To: kmcfarland@starentnetworks.com Subject: gnatsweb/387: sub mark_urls can take over a minute to return for large PR Message-Id: Sender: gnats-prs-admin@gnu.org Errors-To: gnats-prs-admin@gnu.org X-BeenThere: gnats-prs@gnu.org X-Mailman-Version: 2.0.9 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: Copies of bug tracking system messages List-Archive: Date: Mon, 03 Jun 2002 16:21:00 -0000 X-SW-Source: 2002-q2/txt/msg00022.txt.bz2 >Number: 387 >Category: gnatsweb >Synopsis: sub mark_urls can take over a minute to return for large PR >Confidential: no >Severity: serious >Priority: low >Responsible: unassigned >State: open >Class: sw-bug >Submitter-Id: net >Arrival-Date: Mon Jun 03 19:16:55 -0400 2002 >Originator: kmcfarla@starentnetworks.com >Release: v3.99.2 v40-beta1 >Organization: >Environment: linux PC with Apache browser IE 5.50 >Description: Despite our recommendation, we've had user putting large device log file with PR description instead of making it an attachment. We were then finding that PRs with large log files one example was: -rw-r--r-- 1 gnats gnats 549458 May 30 19:57 4443 This PR would take just over a Minute to load in the browser. I debugged through the perl code and was seeing that the sub mark_urls was were all the time was spend...about 1 min just here. This is a nice feature to mark email, urls, etc to be a click away, but not worth the minute to get the PR. I commented this line out and it now loads in about a sec or less. I'd recommend either writing this to be a little faster (like do it in a single pass) or simply remove it. # takes a string, # attempts to make urls, PR references and email addresses in that string into # links: # 'foo bar baz@quux.com flibbet PR# 1234 and furthermore # http://www.abc.com/whatever.html' # is returned as: # 'foo bar baz@quux.com flibbet # PR# 1234 # # http://www.abc.com/whatever.html' # returns the (possibly) modified string # since we need to make three passes over the string, and the results of # one pass would be fodder for another pass (ie. the PR url in a href # would trigger the url matcher), we put each created link into an array, # and substitute in a placeholder. # after we've done all the link substitutions, we go back and replace the # placeholders with the cached links from the array. # it might be possible to order the substitutions so that they didn't # step on each other (urls, then mailto:s, then PRs), but this fails # when presented with ftp urls which include a username: # ftp://user@ftp.foo.com/pub/foo/bar.gz sub mark_urls { >How-To-Repeat: >Fix: file: gnatsweb.pl sub view } else { # make urls and email addresses into live hrefs $val = mark_urls($val); } simple comment out: #$val = mark_urls($val); >Unformatted: _______________________________________________ Gnats-prs mailing list Gnats-prs@gnu.org http://mail.gnu.org/mailman/listinfo/gnats-prs