public inbox for
help / color / mirror / Atom feed
Subject: gnatsweb/398: Missing </td> in Login page HTML
Date: Thu, 25 Jul 2002 11:10:00 -0000	[thread overview]
Message-ID: <> (raw)

>Number:         398
>Category:       gnatsweb
>Synopsis:       Missing </td> in Login page HTML
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    unassigned
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Jul 17 13:57:28 -0400 2002
>Originator:     Michael Hogsett
>Release:        gnatsweb 3.99.3

In sub login_page the following line is missing "</td>" after
the ':'.

print "<tr><td><font color=\"red\"><b>User Name</b></font>:<td>",

This can cause problems if you wrap the output in another table
using the site callbacks.

Using site_callback

create handlers for 'login_page_text' and 'page_end_html'\x18\x13
which wrap the output in a table.  

Such as : 

    if ( $cmd eq 'login_page_text' ) { 
	my     $txt = "<!-- site_callback $cmd @args -->\n";
	$txt = $txt . "<table border=0 cellpadding=0 cellspacing=0><tr><td bgcolor=black>\n";
	$txt = $txt . "<table border=0 cellpadding=4 cellspacing=2>\n";
	$txt = $txt . "<tr><td bgcolor=$site_banner_background>\n";
	$txt = $txt . "Login\n";
	$txt = $txt . "</td></tr><tr><td bgcolor=$light_background>\n";
	$txt = $txt . "<FONT COLOR=black>Log in as \&quot;view\&quot;\n";
	$txt = $txt . "with password \&quot;view\&quot; to view PRs</FONT>\n";
	return ( $txt );

- and - 
    if ( $cmd eq 'page_end_html' ) { 
	my     $txt = "<!-- site_callback $cmd @args -->\n";
    	#$txt = $txt . "<FONT COLOR=red>$cmd @args</FONT><BR>\n";
	if ( $args[0] ne "Login" ) {
	    $txt = $txt . "</td></tr></table></td></tr></table></td></tr></table></body></html>\n";
	} else { 
	    $txt = $txt . "</td></tr></table></td></tr></table>\n";
	return ( $txt );

 - then - 

view in Netscape 4.7

      print "<tr><td><font color=\"red\"><b>User Name</b></font>:</td><td>",

Gnats-prs mailing list

                 reply	other threads:[~2002-07-25 18:10 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).