From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id DA6343858D28 for ; Tue, 24 Jan 2023 14:57:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DA6343858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674572262; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=n3+u2ainkUpc560kBWSERefLzzjgjm0/yT9eq1IYl0s=; b=Fd8tj6jyb84NxAra67ejA85oxAqWzFy6mv7qOmQ30npPu5PTPFHYQAivygyR4kfxaNkpqx 6M1+TJn+OrNarnBrn8Zk/5DQ7AJ3H3QpuLa4d3cnqMJy87Nk4feRBplaUQs86dMjSnpLb7 zliYcGQpY8iNrOIyaAQT1TdLwbCOCvY= Received: from mail-il1-f198.google.com (mail-il1-f198.google.com [209.85.166.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-450-p1rKE0CUOmGuL6dVeRgePA-1; Tue, 24 Jan 2023 09:57:41 -0500 X-MC-Unique: p1rKE0CUOmGuL6dVeRgePA-1 Received: by mail-il1-f198.google.com with SMTP id l14-20020a056e02066e00b0030bff7a1841so10674225ilt.23 for ; Tue, 24 Jan 2023 06:57:41 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=n3+u2ainkUpc560kBWSERefLzzjgjm0/yT9eq1IYl0s=; b=alLHHaYLUz469+s2xD41cnqW62tlcu/7ElZV5MPae2JhLH3xU7I0faiMvJFZDCMgU2 JWJE0LW0ger9uq0/QZCwgyxD26WSemr6LAQy4KjyE+XqVMfsAFON2aLjqKfLbI2K3HGR fciQRRkW+jC+yJUUp1lnwiKyoTXVjEuMcyfBlN2e1bLjxa5vdmwjEPUsMDdVv9baE6Jv JBQ8EtKmQLEu+23nT0BQbZ3FmwDKFwNkHDbDWIvty2nUA+lpkvfjmqehZ56RC1XxJi1D DvYnukOg7F3kLnrVN2lfMtCtLwNALI7PNKY4R/wOVqTu0NdlsiRo/VK3UxoAuaAl+9se GdvA== X-Gm-Message-State: AFqh2ko/WQp62X+OMnPL+7OxgObpUFDR7b3CBbdLS1Q61oW1/v1l0uE7 hZ34UEdooJmE3R3kpSa13TXd/UkvNIeQmaweA8ekWDMw+z/AN5oHCmJXNwRrPcflP56ddhyTsav PqGgl2wSOuHk91SQRsQ== X-Received: by 2002:a05:6e02:1562:b0:30f:3736:25ab with SMTP id k2-20020a056e02156200b0030f373625abmr18998208ilu.28.1674572260591; Tue, 24 Jan 2023 06:57:40 -0800 (PST) X-Google-Smtp-Source: AMrXdXv5+Y/nVSTCcMoVcsIKb9G9uWPF56pXZoktdlsIQy0Tb6MzbC3VUxne1HhKNDu3y+dcdsiWQA== X-Received: by 2002:a05:6e02:1562:b0:30f:3736:25ab with SMTP id k2-20020a056e02156200b0030f373625abmr18998199ilu.28.1674572260358; Tue, 24 Jan 2023 06:57:40 -0800 (PST) Received: from [192.168.0.241] (192-0-145-146.cpe.teksavvy.com. [192.0.145.146]) by smtp.gmail.com with ESMTPSA id c13-20020a92cf4d000000b003024928a9afsm630885ilr.83.2023.01.24.06.57.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Jan 2023 06:57:39 -0800 (PST) Message-ID: <7fe71de8-b31d-9c0a-52ef-840396b707a1@redhat.com> Date: Tue, 24 Jan 2023 09:57:38 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH] Add PT_GNU_SFRAME segment To: Florian Weimer , Mark Wielaard Cc: Indu Bhagat , gnu-gabi@sourceware.org References: <20230123195619.16513-1-indu.bhagat@oracle.com> <088fb3ea96e64f2dcc5e2af1d49bec3fdab3482a.camel@klomp.org> <87o7qof4rs.fsf@oldenburg.str.redhat.com> From: Carlos O'Donell Organization: Red Hat In-Reply-To: <87o7qof4rs.fsf@oldenburg.str.redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 1/24/23 08:20, Florian Weimer via Gnu-gabi wrote: > * Mark Wielaard: > >> Hi Indu, >> >> On Mon, 2023-01-23 at 11:56 -0800, Indu Bhagat via Gnu-gabi wrote: >>> As I submit this patch, I am reminded of my ongoing unease with using the >>> keyword "unwind information" with SFrame format. SFrame format, is the Simple >>> Frame format, which represents the minimal necessary information for >>> backtracing: >>> - Canonical Frame Address (CFA) >>> - Frame Pointer (FP) >>> - Return Address (RA) >>> As such, one can argue that there is a clear distinction between "backtrace" >>> (=simple call trace) and "unwind"(=stack walk + recover state/regs). >>> >>> What do you think will the "correct" terminology here (if there is one) ? >>> Simple Frame format is for backtracing only, but calling it a "backtrace >>> format" also sounds off. May be "backtracing format" ? Simple Frame, SFrame, >>> backtracing format... >>> >>> Thoughts? >> >> What about calling it a "call trace"? >> Although technically it is a "return trace". > > “Stack trace” matches “SFrame”. That's Python, Java etc. terminology > and seems appropriate here, too. Agreed, good point. I'm fine with the use of the word "stack" in this context. I looked at Java's documentation and they use the term "stack trace": https://docs.oracle.com/en/java/javase/19/docs/specs/man/jstack.html Likewise for Python the term is "stack traces": https://docs.python.org/3/library/traceback.html?highlight=stack%20trace That confirms the common usage in Java and Python. That's enough for me to consider "stack traces" a good choice. Note Ruby still calls it a "backtrace" in the context of exceptions: https://docs.ruby-lang.org/en/master/Exception.html#method-i-backtrace but I'd argue "stack trace" is a better choice there too. -- Cheers, Carlos.