From: Florian Weimer <fweimer@redhat.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: Cary Coutant <ccoutant@gmail.com>,
Binutils <binutils@sourceware.org>,
GNU C Library <libc-alpha@sourceware.org>,
gnu-gabi@sourceware.org,
x86-64-abi <x86-64-abi@googlegroups.com>
Subject: Re: RFC: Add PT_GNU_PROPERTY to cover .note.gnu.property section
Date: Mon, 01 Jan 2018 00:00:00 -0000 [thread overview]
Message-ID: <87zhtcz7cg.fsf@oldenburg2.str.redhat.com> (raw)
In-Reply-To: <CAMe9rOp724pNQhndd8_-bVOS=42=0a4Ajsmgi2LUzA1P2BeWvw@mail.gmail.com> (H. J. Lu's message of "Tue, 4 Dec 2018 05:57:45 -0800")
* H. J. Lu:
> diff --git a/ld/testsuite/ld-elf/pr23900-1b.d b/ld/testsuite/ld-elf/pr23900-1b.d
> new file mode 100644
> index 0000000000..e1555c29f6
> --- /dev/null
> +++ b/ld/testsuite/ld-elf/pr23900-1b.d
> @@ -0,0 +1,14 @@
> +#source: pr23900-1.s
> +#ld:
> +#readelf: -l --wide
> +#target: *-*-linux* *-*-gnu* *-*-nacl*
> +
> +#...
> + GNU_PROPERTY .*
> +#...
> + +[0-9]+ +\.note\.gnu\.property
> +#...
> + +[0-9]+ +\.note\.gnu\.property
> +#...
> + +[0-9]+ +\.note\.gnu\.property
> +#...
Sholdn't there be a test that checks that the segment alignment is as
expected?
What happened to the earlier concerns that the presence of
PT_GNU_PROPERTY will break some existing installations?
I would strongly recommended to try harder to get consensus here. I do
not want to be a in a situation were we revise ABI again two years from
now.
Thanks,
Florian
next prev parent reply other threads:[~2018-12-11 10:27 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-01 0:00 RFC: Linux gABI: Add a GNU_PROPERTY_BY_LINKER property H.J. Lu
2018-01-01 0:00 ` Florian Weimer
2018-01-01 0:00 ` H.J. Lu
2018-01-01 0:00 ` Cary Coutant
2018-01-01 0:00 ` H.J. Lu
2018-01-01 0:00 ` Florian Weimer
2018-01-01 0:00 ` H.J. Lu
2018-01-01 0:00 ` Cary Coutant
2018-01-01 0:00 ` H.J. Lu
2018-01-01 0:00 ` H.J. Lu
2018-01-01 0:00 ` RFC: Add PT_GNU_PROPERTY to cover .note.gnu.property section H.J. Lu
2018-01-01 0:00 ` H.J. Lu
2018-01-01 0:00 ` H.J. Lu
2018-01-01 0:00 ` Florian Weimer [this message]
2018-01-01 0:00 ` H.J. Lu
2018-01-01 0:00 ` Cary Coutant
2018-01-01 0:00 ` Mark Wielaard
2018-01-01 0:00 ` H.J. Lu
2018-01-01 0:00 ` Cary Coutant
2018-01-01 0:00 ` H.J. Lu
2018-01-01 0:00 ` Szabolcs Nagy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zhtcz7cg.fsf@oldenburg2.str.redhat.com \
--to=fweimer@redhat.com \
--cc=binutils@sourceware.org \
--cc=ccoutant@gmail.com \
--cc=gnu-gabi@sourceware.org \
--cc=hjl.tools@gmail.com \
--cc=libc-alpha@sourceware.org \
--cc=x86-64-abi@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).