From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31525 invoked by alias); 11 Dec 2018 10:27:33 -0000 Mailing-List: contact gnu-gabi-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: gnu-gabi-owner@sourceware.org Received: (qmail 31496 invoked by uid 89); 11 Dec 2018 10:27:33 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.100.2 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=installations, Hx-languages-length:921 X-Spam-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_HELO_PASS autolearn=ham version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-Spam-User: qpsmtpd, 3 recipients X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 11 Dec 2018 10:27:32 +0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B988EC058CBE; Tue, 11 Dec 2018 10:27:30 +0000 (UTC) Received: from oldenburg2.str.redhat.com (ovpn-116-82.ams2.redhat.com [10.36.116.82]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E9D295D70A; Tue, 11 Dec 2018 10:27:28 +0000 (UTC) From: Florian Weimer To: "H.J. Lu" Cc: Cary Coutant , Binutils , GNU C Library , gnu-gabi@sourceware.org, x86-64-abi Subject: Re: RFC: Add PT_GNU_PROPERTY to cover .note.gnu.property section References: <87ftvoouda.fsf@oldenburg.str.redhat.com> <87k1kyhbki.fsf@oldenburg.str.redhat.com> Date: Mon, 01 Jan 2018 00:00:00 -0000 In-Reply-To: (H. J. Lu's message of "Tue, 4 Dec 2018 05:57:45 -0800") Message-ID: <87zhtcz7cg.fsf@oldenburg2.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Tue, 11 Dec 2018 10:27:30 +0000 (UTC) X-IsSubscribed: yes X-SW-Source: 2018-q4/txt/msg00030.txt.bz2 * H. J. Lu: > diff --git a/ld/testsuite/ld-elf/pr23900-1b.d b/ld/testsuite/ld-elf/pr23900-1b.d > new file mode 100644 > index 0000000000..e1555c29f6 > --- /dev/null > +++ b/ld/testsuite/ld-elf/pr23900-1b.d > @@ -0,0 +1,14 @@ > +#source: pr23900-1.s > +#ld: > +#readelf: -l --wide > +#target: *-*-linux* *-*-gnu* *-*-nacl* > + > +#... > + GNU_PROPERTY .* > +#... > + +[0-9]+ +\.note\.gnu\.property > +#... > + +[0-9]+ +\.note\.gnu\.property > +#... > + +[0-9]+ +\.note\.gnu\.property > +#... Sholdn't there be a test that checks that the segment alignment is as expected? What happened to the earlier concerns that the presence of PT_GNU_PROPERTY will break some existing installations? I would strongly recommended to try harder to get consensus here. I do not want to be a in a situation were we revise ABI again two years from now. Thanks, Florian