From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x141.google.com (mail-il1-x141.google.com [IPv6:2607:f8b0:4864:20::141]) by sourceware.org (Postfix) with ESMTPS id 1298E3982EC4 for ; Wed, 17 Jun 2020 18:23:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 1298E3982EC4 Received: by mail-il1-x141.google.com with SMTP id p5so3198355ile.6 for ; Wed, 17 Jun 2020 11:23:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=IqktpDLea/l+ct6Qe/zxqx8+XlYG9IlbR9NLbuUfBJw=; b=ZYzoPcEOK0M8vr1/NyioQ1HZ0WxefljXlkz4KjGrJtWXh3VXtgdgIWgjg84tpuXxAY +Wm3sdsPPR0J1V8QNSR1dv7ZW3vUS7K2JD6/LWfIrNf6hU/Trdf/LgX74vf0Skf3Lc+s /fjzXrvr+6sOGiTQHl+NjghZztSa6fJDtjZYkQv2uinabKTCkb513glgmz9Zk/geX9FQ wNN8VJbT2dYaUn7pKAf6+czA4tu8KFUujaqP8ldShB4JaaSOGg50Iyr75DhgqU65hPQ5 g7LXlSnOd5AFl+/FfcuWkj7qaMPSsXM+73mhxZpz3kdSmaipY5mQ2pBMwzJVTZ4ur+Ay 8hRw== X-Gm-Message-State: AOAM530Oowr+9hF7U+anmOLK54ecnvv7TqJITgb+oIHFkbqZdcrPlXDI HEJEbTQHdhAg1XKb0sPJrXte2zx82hiQemWgPZ8= X-Google-Smtp-Source: ABdhPJyfwMU1ohxaWcBuRTQihzpiTGbXjh3OWP0PLNGQq+waGjJ6DPJwuIGpjYPxoHWZ98PdUNemNExMUTAv48Oxpc0= X-Received: by 2002:a92:cd49:: with SMTP id v9mr179759ilq.272.1592418237514; Wed, 17 Jun 2020 11:23:57 -0700 (PDT) MIME-Version: 1.0 References: <20200617135945.12716-1-vivek@collabora.com> In-Reply-To: From: Cary Coutant Date: Wed, 17 Jun 2020 11:23:46 -0700 Message-ID: Subject: Re: [RFC][PATCH v2 0/6] binutils patches to add DT_GNU_UNIQUE To: Vivek Das Mohapatra Cc: Michael Matz , gnu-gabi@sourceware.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gnu-gabi@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gnu-gabi mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Jun 2020 18:23:59 -0000 > I should open by saying I originally implemented this as a new bitfield > value for the payload of DT_FLAGS_1, but was told a new DT_GNU_=E2=80=A6 = section > might be more palatable/portable/less-conflict-prone. I don't know why you were advised that, but it seems to me that using DT_FLAGS_1 is the right approach. Dynamic table tags are meant to convey a value other than a simple boolean; if all you need is a flag, well, that's what DT_FLAGS and DT_FLAGS_1 are for. For precedent, note that the old dynamic table entries DT_SYMBOLIC, DT_TEXTREL, and DT_BIND_NOW have all been replaced by flags in DT_FLAGS. DT_FLAGS_1 is a Gnu extension, so it's the place for a Gnu-specific flag. Perhaps the concern was that DT_FLAGS_1 is also used by Solaris, so I suppose you'd want to get agreement from them to use one of those bits. You could always add a DT_GNU_FLAGS if DT_FLAGS_1 isn't acceptable. -cary