From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 33CB93858D1E for ; Tue, 24 Jan 2023 13:10:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 33CB93858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674565826; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gURMyFGpIT42QAexOfEU8Rq3BtjIkPdJSebKly9M1jU=; b=hmlZz+QJfsGpYI46brziqOCMJ/6VAFkzWNrEJUdS8dZKbloNogUAXGZmIHK53AfV7zEfpy GVEsQ6wi8r2EpHiJRh2A8bUtS/Yk82PRwDKyT4vnCnzOc9fXp9lDazS6skmeKtuSF7WylF idXBRH7/L8GSqFDYn356Nq1IOL46BW0= Received: from mail-il1-f200.google.com (mail-il1-f200.google.com [209.85.166.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-358-quWLme48NH-0o4-pTML6nA-1; Tue, 24 Jan 2023 08:10:25 -0500 X-MC-Unique: quWLme48NH-0o4-pTML6nA-1 Received: by mail-il1-f200.google.com with SMTP id i7-20020a056e021b0700b003033a763270so10383015ilv.19 for ; Tue, 24 Jan 2023 05:10:25 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=gURMyFGpIT42QAexOfEU8Rq3BtjIkPdJSebKly9M1jU=; b=v1qBJzKUsEpYo+0/wtRzf+HtyF7zYwjk2/mZVRY5tk7oJrbUttWZtvvmuKO5VAl/Tj +I5WuDBCxI3fCvZBCuOMiKYCNdzjXHNYzQkXNi6A1S2NO00Fk4kQUvNWMO7bDgsP2pX/ V5dQAbNMFzJiY7qNZOrSSoFI4Olj3DZXiMuHbJiqXH93M9BmBsIB6e/2xnJO/FMbEhyM JMjcSSfaB14Asp5EVS0PFqAxm046ItQy9vNEQ6zyYuvSt7OkFLOiQYxHk+r+SX1O+ASE htPu90apjPXKkmksC/hzCjaDPzEtVQh8IHIwktngBO1GlLxMhkhfjjCicFYeWk7ct3kT c2cg== X-Gm-Message-State: AFqh2kr30Kp/1/aaN69bx27cnmlJL0xpGrOnlokhLx4Wk02AlS5RxGXo U8dV8R7i625IbNN55FT/3bj8B+Laj1ZuSmZVUsSk8wkj45TjIiXZEHu38K89gM9S9JVX1cJzijt VaxJigzaQg1CFvnJG7A== X-Received: by 2002:a6b:f014:0:b0:6e0:380b:b900 with SMTP id w20-20020a6bf014000000b006e0380bb900mr20144788ioc.12.1674565824500; Tue, 24 Jan 2023 05:10:24 -0800 (PST) X-Google-Smtp-Source: AMrXdXsRJl8PLwg1N2JNhsmau4pM57lBWKz4LVLlzzzAWXHR7wIyq+xeNX/kXyQ96aN7I8egYVhFeA== X-Received: by 2002:a6b:f014:0:b0:6e0:380b:b900 with SMTP id w20-20020a6bf014000000b006e0380bb900mr20144775ioc.12.1674565824231; Tue, 24 Jan 2023 05:10:24 -0800 (PST) Received: from [192.168.0.241] (192-0-145-146.cpe.teksavvy.com. [192.0.145.146]) by smtp.gmail.com with ESMTPSA id f6-20020a056602070600b00704608527d1sm572000iox.37.2023.01.24.05.10.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Jan 2023 05:10:23 -0800 (PST) Message-ID: Date: Tue, 24 Jan 2023 08:10:22 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH] Add PT_GNU_SFRAME segment To: Mark Wielaard , Indu Bhagat , gnu-gabi@sourceware.org References: <20230123195619.16513-1-indu.bhagat@oracle.com> <088fb3ea96e64f2dcc5e2af1d49bec3fdab3482a.camel@klomp.org> From: Carlos O'Donell Organization: Red Hat In-Reply-To: <088fb3ea96e64f2dcc5e2af1d49bec3fdab3482a.camel@klomp.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 1/24/23 06:13, Mark Wielaard wrote: > Hi Indu, > > On Mon, 2023-01-23 at 11:56 -0800, Indu Bhagat via Gnu-gabi wrote: >> As I submit this patch, I am reminded of my ongoing unease with using the >> keyword "unwind information" with SFrame format. SFrame format, is the Simple >> Frame format, which represents the minimal necessary information for >> backtracing: >> - Canonical Frame Address (CFA) >> - Frame Pointer (FP) >> - Return Address (RA) >> As such, one can argue that there is a clear distinction between "backtrace" >> (=simple call trace) and "unwind"(=stack walk + recover state/regs). >> >> What do you think will the "correct" terminology here (if there is one) ? >> Simple Frame format is for backtracing only, but calling it a "backtrace >> format" also sounds off. May be "backtracing format" ? Simple Frame, SFrame, >> backtracing format... >> >> Thoughts? > > What about calling it a "call trace"? > Although technically it is a "return trace". You are "stack walking" in this case, either following a backchain, or sequence of chained values that allow you to walk the stack and identify call frames. You are indeed walking the list of called functions via their call frames. I like "call trace" as a technical term. We are walking the call frames and taking a trace of them, rather than unwinding. So "call trace format"? -- Cheers, Carlos.