From: Michael Matz <matz@suse.de>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: Rich Felker <dalias@libc.org>, Cary Coutant <ccoutant@gmail.com>,
Carlos O'Donell <carlos@redhat.com>,
Florian Weimer <fweimer@redhat.com>,
Szabolcs Nagy <nsz@port70.net>,
Jan Beulich <JBeulich@suse.com>,
Binutils <binutils@sourceware.org>,
gnu-gabi@sourceware.org
Subject: Re: RFC: Add GNU_PROPERTY_NEED_PHDRS
Date: Mon, 01 Jan 2018 00:00:00 -0000 [thread overview]
Message-ID: <alpine.LSU.2.21.1810021447240.7867@wotan.suse.de> (raw)
In-Reply-To: <CAMe9rOrrshfuAEx3J1E6bZwk7zyMpud-_=YU7rWpj8nx8cgfwQ@mail.gmail.com>
Hi,
On Fri, 28 Sep 2018, H.J. Lu wrote:
> >> AT_PHDR to main, which points to the unmmaped address. We can ask
> >> for kernel change or make kernel happy.
> >
> > Kernel change does not help because nobody is obligated to use a new
> > kernel. Binutils would be producing binaries that don't work on
> > existing kernels (if the note hack were reverted or if similar changes
> > were added to other archs without a note hack; right now of course
> > it's working again).
>
> True.
>
> >> My current .note.gnu.property patch only works for x86. We can add
> >>
> >> #define GNU_PROPERTY_PHDRS 3
> >>
> >> so that it can be used for all targets.
> >
> > What would this do?
>
> These are what I have in mind.
I don't see how the patches fix anything, in particular making sure that
the phdrs are always mapped. If your intention is (it would be good if
you can explain it with words) that they only would be made mapped if this
new property is set, then I'd disagree. I think they should always be
made mapped unconditionally. There are two ways for this: (a) add a new
PT_LOAD that covers them, (b) move the phdrs into the ro data segment. I
find all approaches that add properties or new section types or anything
else that needs documentation and definition dubious.
Ciao,
Michael.
next prev parent reply other threads:[~2018-10-02 14:52 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-01 0:00 H.J. Lu
2018-01-01 0:00 ` Michael Matz [this message]
2018-01-01 0:00 ` H.J. Lu
2018-01-01 0:00 ` Michael Matz
2018-01-01 0:00 ` H.J. Lu
2018-01-01 0:00 ` Michael Matz
2018-01-01 0:00 ` H.J. Lu
2018-01-01 0:00 ` Michael Matz
2018-01-01 0:00 ` H.J. Lu
2018-01-01 0:00 ` Cary Coutant
2018-01-01 0:00 ` Alan Modra
2018-01-01 0:00 ` Cary Coutant
2018-01-01 0:00 ` Alan Modra
2018-01-01 0:00 ` Cary Coutant
2018-01-01 0:00 ` H.J. Lu
2018-01-01 0:00 ` Rich Felker
2018-01-01 0:00 ` H.J. Lu
2018-01-01 0:00 ` Alan Modra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LSU.2.21.1810021447240.7867@wotan.suse.de \
--to=matz@suse.de \
--cc=JBeulich@suse.com \
--cc=binutils@sourceware.org \
--cc=carlos@redhat.com \
--cc=ccoutant@gmail.com \
--cc=dalias@libc.org \
--cc=fweimer@redhat.com \
--cc=gnu-gabi@sourceware.org \
--cc=hjl.tools@gmail.com \
--cc=nsz@port70.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).