From: Gerard Jungman <jungman@lanl.gov>
To: Lowell Johnson <ldj00@sio.midco.net>
Cc: picca@synchrotron-soleil.fr, gsl-discuss@sources.redhat.com
Subject: Re: cvs version: make check FAIL
Date: Thu, 25 May 2006 20:12:00 -0000 [thread overview]
Message-ID: <1148587827.3603.18.camel@bellerophon.lanl.gov> (raw)
In-Reply-To: <200605241728.02573.ldj00@sio.midco.net>
On Wed, 2006-05-24 at 17:28 -0500, Lowell Johnson wrote:
> On Wednesday 24 May 2006 01:42 am, picca@synchrotron-soleil.fr wrote:
> > Hello
> >
> > Instead of computing 2 times fabs(fn), why not storing it in a
> > variable ?
> >
> > result->val = fn;
> > - result->err = GSL_DBL_EPSILON*fabs(fn);
> > + result->err = 2.0*GSL_DBL_EPSILON;
> > + double factor = fabs(fn);
> > + if (factor > 1.0)
> > + result->err *= factor;
Hi. I have not been following this discussion,
but it looks like there is a bug in the above.
result->err = 2.0*GSL_DBL_EPSILON;
should probably read
result->err += 2.0*GSL_DBL_EPSILON;
I just happened to notice it out of the corner
of my eye. Hope I'm not completely off base
here.
--
Gerard Jungman <jungman@lanl.gov>
Los Alamos National Laboratory
next prev parent reply other threads:[~2006-05-25 20:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-23 22:03 Giulio Bottazzi
2006-05-24 2:09 ` Lowell Johnson
2006-05-24 6:42 ` Lowell Johnson
2006-05-24 14:28 ` picca
2006-05-25 20:11 ` Lowell Johnson
2006-05-25 20:12 ` Gerard Jungman [this message]
2006-05-25 20:18 ` Gerard Jungman
2006-05-29 16:10 ` Giulio Bottazzi
2006-06-01 12:33 ` Brian Gough
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1148587827.3603.18.camel@bellerophon.lanl.gov \
--to=jungman@lanl.gov \
--cc=gsl-discuss@sources.redhat.com \
--cc=ldj00@sio.midco.net \
--cc=picca@synchrotron-soleil.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).