From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2595 invoked by alias); 24 Nov 2008 17:49:37 -0000 Received: (qmail 2495 invoked by uid 22791); 24 Nov 2008 17:49:36 -0000 X-Spam-Check-By: sourceware.org Received: from qmta02.emeryville.ca.mail.comcast.net (HELO QMTA02.emeryville.ca.mail.comcast.net) (76.96.30.24) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 24 Nov 2008 17:48:50 +0000 Received: from OMTA10.emeryville.ca.mail.comcast.net ([76.96.30.28]) by QMTA02.emeryville.ca.mail.comcast.net with comcast id j3tb1a0070cQ2SLA25ogGF; Mon, 24 Nov 2008 17:48:40 +0000 Received: from hippogriff.homeunix.org ([75.70.82.180]) by OMTA10.emeryville.ca.mail.comcast.net with comcast id j5of1a00D3tRyZn8W5ofzT; Mon, 24 Nov 2008 17:48:40 +0000 X-Authority-Analysis: v=1.0 c=1 a=4dazYdDCpgMA:10 a=bO-eAlOBOzcA:10 a=wFwrc-QRiU3cLVviajcA:9 a=DHw2VJJ43xEeXXRsMxQbNbMrtEsA:4 a=XF7b4UCPwd8A:10 Received: by hippogriff.homeunix.org (Postfix, from userid 1000) id 98AD4CB6BD; Mon, 24 Nov 2008 10:58:54 -0700 (MST) Date: Mon, 08 Dec 2008 21:12:00 -0000 From: Patrick Alken To: gsl-discuss@sourceware.org Cc: Rhys Ulerich Subject: Re: [Help-gsl] Submitted patch to add bspline derivative capabilities Message-ID: <20081124175854.GA994@hippogriff.homeunix.org> References: <4a00655d0811191412t371982eev1bb77325719860f7@mail.gmail.com> <20081119235047.GA18604@hippogriff.homeunix.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17+20080114 (2008-01-14) Mailing-List: contact gsl-discuss-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gsl-discuss-owner@sourceware.org X-SW-Source: 2008-q4/txt/msg00035.txt.bz2 The new code looks clean and very well written. I made a test program comparing the gsl_bspline_eval_deriv output directly with PPPACK's bvalue() routine, which is an independent implementation of bspline derivatives (gsl_bspline_eval_deriv is based on bsplvd()). The results look fine. I also ran it through valgrind with good results. I think it can be put into the next release. Patrick On Mon, Nov 24, 2008 at 03:37:57PM +0000, Brian Gough wrote: > At Wed, 19 Nov 2008 16:50:47 -0700, > Patrick Alken wrote: > > > > I'm moving this discussion to the gsl-discuss list. Good work! > > This is something several people have been asking for and I haven't > > had any time to work on. > > > > I will take a look at the patch in the next few days. > > Patrick, I'm happy for you to take the decision on this wrt the 1.12 > release. The main thing we want to avoid at this stage is breaking > the build in ways that we might not detect in our own testing. > > -- > Brian Gough