From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1133 invoked by alias); 15 Jun 2009 17:38:35 -0000 Received: (qmail 1123 invoked by uid 22791); 15 Jun 2009 17:38:34 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from qmta06.emeryville.ca.mail.comcast.net (HELO QMTA06.emeryville.ca.mail.comcast.net) (76.96.30.56) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 15 Jun 2009 17:38:27 +0000 Received: from OMTA09.emeryville.ca.mail.comcast.net ([76.96.30.20]) by QMTA06.emeryville.ca.mail.comcast.net with comcast id 4HPE1c0070S2fkCA6HeSQJ; Mon, 15 Jun 2009 17:38:26 +0000 Received: from hippogriff.homeunix.org ([24.8.141.236]) by OMTA09.emeryville.ca.mail.comcast.net with comcast id 4HeR1c00V56DT748VHeRB2; Mon, 15 Jun 2009 17:38:26 +0000 Received: by hippogriff.homeunix.org (Postfix, from userid 1000) id 667A7CB6D2; Mon, 15 Jun 2009 11:39:17 -0600 (MDT) Date: Mon, 15 Jun 2009 17:38:00 -0000 From: Patrick Alken To: Rhys Ulerich Cc: gsl-discuss@sourceware.org Subject: Re: [PATCH] Add Greville abscissae functionality to B-splines Message-ID: <20090615173917.GA31020@hippogriff.homeunix.org> References: <20090614165708.22998.15238.stgit@localhost> <4a00655d0906150743h73d5d019w58a32db374861309@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <4a00655d0906150743h73d5d019w58a32db374861309@mail.gmail.com> User-Agent: Mutt/1.5.18 (2008-05-17) Mailing-List: contact gsl-discuss-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gsl-discuss-owner@sourceware.org X-SW-Source: 2009-q2/txt/msg00021.txt.bz2 Nice work, I have added your patch to the repository and inserted the appropriate gsl_bspline_free's in test.c. Patrick On Mon, Jun 15, 2009 at 09:43:46AM -0500, Rhys Ulerich wrote: > Thanks guys. > > FYI, I woke up this morning and realized I forgot a gsl_bspline_free > call at the bottom of each of the unit test blocks in test.c. > > - Rhys > > On Mon, Jun 15, 2009 at 5:26 AM, Brian Gough wrote: > > At Sun, 14 Jun 2009 12:02:10 -0500, > > Rhys Ulerich wrote: > >>  This change adds computing Greville abscissae to the GSL B-spline > >>  routines.  Updates to unit tests and documentation are included. > >>  The routines are written so that if the b-spline classes have lower > >>  continuity basis added later (i.e. by adding multiple knots per > >>  interior breakpoint), these should continue to do the right thing. > > > > Cool. I'll let Patrick take care of these. > > > > -- > > Brian Gough > > > >