From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31690 invoked by alias); 17 Jun 2009 22:11:28 -0000 Received: (qmail 31630 invoked by uid 22791); 17 Jun 2009 22:11:27 -0000 X-SWARE-Spam-Status: No, hits=-0.8 required=5.0 tests=AWL,BAYES_50 X-Spam-Check-By: sourceware.org Received: from qmta12.emeryville.ca.mail.comcast.net (HELO QMTA12.emeryville.ca.mail.comcast.net) (76.96.27.227) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 17 Jun 2009 22:11:21 +0000 Received: from OMTA01.emeryville.ca.mail.comcast.net ([76.96.30.11]) by QMTA12.emeryville.ca.mail.comcast.net with comcast id 54Qa1c0060EPchoACABM7Q; Wed, 17 Jun 2009 22:11:21 +0000 Received: from hippogriff.homeunix.org ([24.8.141.236]) by OMTA01.emeryville.ca.mail.comcast.net with comcast id 5ABL1c00A56DT748MABLnX; Wed, 17 Jun 2009 22:11:21 +0000 Received: by hippogriff.homeunix.org (Postfix, from userid 1000) id 73109CBB0E; Wed, 17 Jun 2009 16:12:22 -0600 (MDT) Date: Wed, 17 Jun 2009 22:11:00 -0000 From: Patrick Alken To: gsl-discuss@sourceware.org Subject: Re: [PATCH] Add Greville abscissae functionality to B-splines Message-ID: <20090617221222.GA31761@hippogriff.homeunix.org> References: <20090614165708.22998.15238.stgit@localhost> <4a00655d0906150743h73d5d019w58a32db374861309@mail.gmail.com> <20090615173917.GA31020@hippogriff.homeunix.org> <4a00655d0906151113y5efb05a7gde0b73d7afc9d0bf@mail.gmail.com> <20090615183150.GA6198@hippogriff.homeunix.org> <4a00655d0906171454h411b717ao842bdb618513e3b9@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <4a00655d0906171454h411b717ao842bdb618513e3b9@mail.gmail.com> User-Agent: Mutt/1.5.18 (2008-05-17) Mailing-List: contact gsl-discuss-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gsl-discuss-owner@sourceware.org X-SW-Source: 2009-q2/txt/msg00025.txt.bz2 I'll add that I've never used Greville abscissae before, but did do some reading about it when I looked at your patch. I also found a matlab code on it which I used to verify some of your test cases, which did look correct. Maybe it would be worthwhile to back out this patch from the git and do more testing on it first? I'll be out of town for 2 weeks and won't be able to look at your new patch until I get back. Patrick On Wed, Jun 17, 2009 at 04:54:21PM -0500, Rhys Ulerich wrote: > Hi Patrick (and all), > > Attached is a patch to apply atop my last Greville abscissae > contribution. I had badly misunderstood some of the details when I > implemented it originally. This new patch corrects the > implementation, units tests, and documentation. > > - Rhys > > On Mon, Jun 15, 2009 at 1:31 PM, Patrick > Alken wrote: > > Oops, I must have ran some autoconf tools and changed that file. > > I think its fixed now. > > > > Patrick > > > > On Mon, Jun 15, 2009 at 01:13:32PM -0500, Rhys Ulerich wrote: > >> Hi Patrick, > >> > >> I noticed in the commit there were changes made to install.sh > >> (http://git.savannah.gnu.org/gitweb/?p=gsl.git;a=commit;h=ccccc3cb7630ea43bdf365bcbaec71e31f8aea91). > >>  Were those deliberate? > >> > >> - Rhys > >> > >> On Mon, Jun 15, 2009 at 12:39 PM, Patrick > >> Alken wrote: > >> > Nice work, I have added your patch to the repository and > >> > inserted the appropriate gsl_bspline_free's in test.c. > >> > > >> > Patrick > >> > > >> > On Mon, Jun 15, 2009 at 09:43:46AM -0500, Rhys Ulerich wrote: > >> >> Thanks guys. > >> >> > >> >> FYI, I woke up this morning and realized I forgot a gsl_bspline_free > >> >> call at the bottom of each of the unit test blocks in test.c. > >> >> > >> >> - Rhys > >> >> > >> >> On Mon, Jun 15, 2009 at 5:26 AM, Brian Gough wrote: > >> >> > At Sun, 14 Jun 2009 12:02:10 -0500, > >> >> > Rhys Ulerich wrote: > >> >> >>  This change adds computing Greville abscissae to the GSL B-spline > >> >> >>  routines.  Updates to unit tests and documentation are included. > >> >> >>  The routines are written so that if the b-spline classes have lower > >> >> >>  continuity basis added later (i.e. by adding multiple knots per > >> >> >>  interior breakpoint), these should continue to do the right thing. > >> >> > > >> >> > Cool. I'll let Patrick take care of these. > >> >> > > >> >> > -- > >> >> > Brian Gough > >> >> > > >> >> > > >> > > >