From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4834 invoked by alias); 2 May 2011 22:36:53 -0000 Received: (qmail 4758 invoked by uid 22791); 2 May 2011 22:36:52 -0000 X-SWARE-Spam-Status: No, hits=-1.2 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from fencepost.gnu.org (HELO fencepost.gnu.org) (140.186.70.10) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 02 May 2011 22:36:38 +0000 Received: from localhost ([127.0.0.1]:35806 helo=fencepost.gnu.org) by fencepost.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QH1jI-0005cZ-OZ; Mon, 02 May 2011 18:36:36 -0400 Date: Mon, 02 May 2011 22:36:00 -0000 Message-ID: <43pqo0g27g.wl%bjg@gnu.org> From: Brian Gough To: "Brian Gladman" Cc: Subject: Re: GSL 1.14.91 Test Release In-Reply-To: <0D8EB1B04D804720822C2911C9312228@MobileSlave> References: <0D8EB1B04D804720822C2911C9312228@MobileSlave> User-Agent: Wanderlust/2.15.6 (Almost Unreal) Emacs/23.2 Mule/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Mailing-List: contact gsl-discuss-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gsl-discuss-owner@sourceware.org X-SW-Source: 2011-q2/txt/msg00013.txt.bz2 At Sun, 1 May 2011 14:40:45 +0100, Brian Gladman wrote: > However cquad.c uses isfinite(x) directly and hence bypasses the alternative > version when isfinite is not available (which it isn't in VC++) and causes a > linking failure. Thanks, for consistency with the rest of the code I've changed cquad.c to use finite(x). The two functions finite() and isfinite() should be handled symmetrically in the configure script but it's simpler to stick with finite() in this case. > The header guard in gsl_odeiv2.h should be __GSL_ODEIV2_H__ to avoid a > conflict with that in gsl_odeiv.h Good catch, thank you.