From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5545 invoked by alias); 15 Jun 2009 18:14:02 -0000 Received: (qmail 5536 invoked by uid 22791); 15 Jun 2009 18:14:01 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail-fx0-f210.google.com (HELO mail-fx0-f210.google.com) (209.85.220.210) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 15 Jun 2009 18:13:55 +0000 Received: by fxm6 with SMTP id 6so4318042fxm.24 for ; Mon, 15 Jun 2009 11:13:52 -0700 (PDT) MIME-Version: 1.0 Received: by 10.216.47.204 with SMTP id t54mr2459121web.75.1245089632195; Mon, 15 Jun 2009 11:13:52 -0700 (PDT) In-Reply-To: <20090615173917.GA31020@hippogriff.homeunix.org> References: <20090614165708.22998.15238.stgit@localhost> <4a00655d0906150743h73d5d019w58a32db374861309@mail.gmail.com> <20090615173917.GA31020@hippogriff.homeunix.org> From: Rhys Ulerich Date: Mon, 15 Jun 2009 18:14:00 -0000 Message-ID: <4a00655d0906151113y5efb05a7gde0b73d7afc9d0bf@mail.gmail.com> Subject: Re: [PATCH] Add Greville abscissae functionality to B-splines To: Patrick Alken Cc: gsl-discuss@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Mailing-List: contact gsl-discuss-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gsl-discuss-owner@sourceware.org X-SW-Source: 2009-q2/txt/msg00022.txt.bz2 Hi Patrick, I noticed in the commit there were changes made to install.sh (http://git.savannah.gnu.org/gitweb/?p=3Dgsl.git;a=3Dcommit;h=3Dccccc3cb763= 0ea43bdf365bcbaec71e31f8aea91). Were those deliberate? - Rhys On Mon, Jun 15, 2009 at 12:39 PM, Patrick Alken wrote: > Nice work, I have added your patch to the repository and > inserted the appropriate gsl_bspline_free's in test.c. > > Patrick > > On Mon, Jun 15, 2009 at 09:43:46AM -0500, Rhys Ulerich wrote: >> Thanks guys. >> >> FYI, I woke up this morning and realized I forgot a gsl_bspline_free >> call at the bottom of each of the unit test blocks in test.c. >> >> - Rhys >> >> On Mon, Jun 15, 2009 at 5:26 AM, Brian Gough w= rote: >> > At Sun, 14 Jun 2009 12:02:10 -0500, >> > Rhys Ulerich wrote: >> >> =A0This change adds computing Greville abscissae to the GSL B-spline >> >> =A0routines. =A0Updates to unit tests and documentation are included. >> >> =A0The routines are written so that if the b-spline classes have lower >> >> =A0continuity basis added later (i.e. by adding multiple knots per >> >> =A0interior breakpoint), these should continue to do the right thing. >> > >> > Cool. I'll let Patrick take care of these. >> > >> > -- >> > Brian Gough >> > >> > >