From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20509 invoked by alias); 24 Jun 2009 16:49:41 -0000 Received: (qmail 20499 invoked by uid 22791); 24 Jun 2009 16:49:40 -0000 X-SWARE-Spam-Status: No, hits=-1.1 required=5.0 tests=AWL,BAYES_00,J_CHICKENPOX_61,SARE_MSGID_LONG40,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail-ew0-f228.google.com (HELO mail-ew0-f228.google.com) (209.85.219.228) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 24 Jun 2009 16:49:34 +0000 Received: by ewy28 with SMTP id 28so1487095ewy.24 for ; Wed, 24 Jun 2009 09:49:32 -0700 (PDT) MIME-Version: 1.0 Received: by 10.216.26.200 with SMTP id c50mr480291wea.61.1245862172184; Wed, 24 Jun 2009 09:49:32 -0700 (PDT) In-Reply-To: <4a00655d0906230958s521f52a1k5bcc9959adc862d@mail.gmail.com> References: <4a00655d0906211327x742b7224of110fa0621fbbad9@mail.gmail.com> <4a00655d0906211331y127e5693uda4805cf347561b3@mail.gmail.com> <87tz263nnd.wl%bjg@network-theory.co.uk> <4a00655d0906230958s521f52a1k5bcc9959adc862d@mail.gmail.com> From: Rhys Ulerich Date: Wed, 24 Jun 2009 16:49:00 -0000 Message-ID: <4a00655d0906240949h29df5535k327ccb03d8d76f12@mail.gmail.com> Subject: Re: [PATCH] Adding fixed-order Gauss-Legendre integration routines To: Brian Gough Cc: gsl-discuss@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Mailing-List: contact gsl-discuss-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gsl-discuss-owner@sourceware.org X-SW-Source: 2009-q2/txt/msg00033.txt.bz2 In that patch I screwed up the order of the GSL_ERROR_NULL vs free calls within gsl_integration_glfixed_table, e.g. w =3D (double *) malloc(m * sizeof(double)); if (w =3D=3D 0) { GSL_ERROR_NULL ("failed to allocate space for weights", GSL_ENOMEM); free(x); } should definitely have their order flipped. The problem appears once again just below those lines. - Rhys On Tue, Jun 23, 2009 at 11:58 AM, Rhys Ulerich wrot= e: >> Could you redo the patch without the whitespace changes to make it >> easier to see the actual changes, thanks. > > Definitely (attached) =A0Didn't know about that git format-patch > argument until just now... > > - Rhys >