public inbox for gsl-discuss@sourceware.org
 help / color / mirror / Atom feed
From: Patrick Alken <patrick.alken@Colorado.EDU>
To: "gsl-discuss@sourceware.org" <gsl-discuss@sourceware.org>,
	 diazona@ellipsix.net
Subject: Re: [Help-gsl] Getting an extension listed on GSL page
Date: Fri, 03 Jan 2014 19:00:00 -0000	[thread overview]
Message-ID: <52C708E1.6010601@colorado.edu> (raw)
In-Reply-To: <520EB115.9070606@ellipsix.net>

Hi David, I'm moving this thread over to gsl-discuss from help-gsl.

I've been taking a look at your interp2d code since I'm currently doing 
some work which needs 2d interpolation. I like your coding style and 
think this should be moved into the repository at some point.

Just a few initial thoughts:

1. Your INDEX_2D macro for indexing the z array appears to use 
column-major ordering, even though the comment in the .h file says 
row-major. IE: it is currently defined as:

#define INDEX_2D(xi, yi, xsize, ysize) ((yi) * (xsize) + (xi))

which would store each column contiguously in memory instead of each 
row. The GSL gsl_matrix structure uses row-major ordering (see 
gsl_matrix_double.h):

283   return m->data[i * m->tda + j] ;

and so if a user wants to store their 2D grid in a gsl_matrix, its not 
straightforward to just pass m->data as the z array argument to your 
functions; they'd have to transpose first.

2. It would be really great if you could document your library with 
texinfo so when we fold the code into the repository the docs are ready 
to go. You can look at some other extensions for examples (ie see the 
doc/alf.texi file in the ALF extension)

Patrick

On 08/16/2013 05:09 PM, David Zaslavsky wrote:
> Hi there,
>
> For quite some time I've been working on a 2D interpolation library
> compatible with the GSL. I've mentioned it a couple times on this list.
> With some recent work it's gotten to the point where I consider it
> ready for a first release. How would I go about getting it listed in the
> "Extensions" section on the GSL web page?
>
> Also if anyone would like to try compiling and running the test suite,
> I'd appreciate knowing about any bugs that pop up. I've only tried it on
> Linux with GCC 4.6.3.
>   https://github.com/diazona/interp2d
>
> :) David
>

       reply	other threads:[~2014-01-03 19:00 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <520EB115.9070606@ellipsix.net>
2014-01-03 19:00 ` Patrick Alken [this message]
2014-01-05 20:31   ` David Zaslavsky
2014-01-06 16:58     ` interp2d discussion Patrick Alken
2014-01-10  6:05       ` David Zaslavsky
2014-01-10  6:11       ` David Zaslavsky
2014-01-10 16:37         ` Patrick Alken
2014-01-11  0:28           ` jeremy theler
2014-01-11  1:55             ` Patrick Alken
2014-01-14  1:51               ` jeremy theler
2014-01-14  2:23                 ` Patrick Alken
2014-01-11  1:58             ` David Zaslavsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52C708E1.6010601@colorado.edu \
    --to=patrick.alken@colorado.edu \
    --cc=diazona@ellipsix.net \
    --cc=gsl-discuss@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).