From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 43182 invoked by alias); 19 Nov 2015 22:21:17 -0000 Mailing-List: contact gsl-discuss-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gsl-discuss-owner@sourceware.org Received: (qmail 43172 invoked by uid 89); 19 Nov 2015 22:21:16 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: na01-bn1-obe.outbound.protection.outlook.com Received: from mail-bn1on0145.outbound.protection.outlook.com (HELO na01-bn1-obe.outbound.protection.outlook.com) (157.56.110.145) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA256 encrypted) ESMTPS; Thu, 19 Nov 2015 22:21:15 +0000 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=patrick.alken@colorado.edu; Received: from palken-co-ll.ngdc.noaa.gov (140.172.179.43) by BN3PR0301MB0900.namprd03.prod.outlook.com (10.160.156.142) with Microsoft SMTP Server (TLS) id 15.1.325.17; Thu, 19 Nov 2015 22:21:11 +0000 Subject: Re: Bug #45926 To: , References: From: Patrick Alken Message-ID: <564E4B52.5040105@colorado.edu> Date: Thu, 19 Nov 2015 22:21:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: CY1PR12CA0031.namprd12.prod.outlook.com (25.160.137.41) To BN3PR0301MB0900.namprd03.prod.outlook.com (25.160.156.142) X-Microsoft-Exchange-Diagnostics: 1;BN3PR0301MB0900;2:oDoVWXcRUgeKYdXkZnY2WzxFl+tAr+vD3o+YD2JfTP2zmj9ORMVzHUkSTcbgzU02bsuruF4FIwY1avvei2ZR8NMmN+ecr0Oe96p+DVnjNA0waSDRMCNkPxWTMJN2moxi8DurJS9X5oF4Vd7ZceSgK8f5mYXz1v1r0FHpM/dtjSo=;3:1lF+/zvinZLXH0FvMWgwj1SpdtOVYzexbyxwSYRjWa0qSHPtmYVEd78UjwDrzKhjI5BYxcRIDvI5GESnSDb67vtTsMfkRNRbd/YAi8znCL/3xCjTDI6u6RaW/YFGKKvfITVqEphiaQBgmUPpY7TOnQ==;25:YNDuCuOZA+3TVxK6NKOdNRpLdrIePGxYCNVuGwnZt3YW+PxVJP/t+aMECnsO5S/t4i1pUkpPBAUkxaeHGmgsq5QFR5QwcDjU4lG6e5+QuSbcn+lsSZVkpBtlv8PM0Ouys22Bqjh4/Ibjx8qRi9ZHFep7gsLyxHaFITcDFmC2Dmrcdx/Xgv0Ad2NWfOgpKtTu9BqgwjXK/2cEyUBEh5t7atDpuyxHoiSP6g8BJl6opi7sFwfu9eApm+YzpVu99XVqd3I0IO1AkK0kZsR92eXPtw== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN3PR0301MB0900; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(520078)(5005006)(10201501046)(3002001);SRVR:BN3PR0301MB0900;BCL:0;PCL:0;RULEID:;SRVR:BN3PR0301MB0900; X-Microsoft-Exchange-Diagnostics: 1;BN3PR0301MB0900;4:NjTvLp0oMdPpVZ6H6LAbAdJvH+K/I68fVUfBT2IpLZGcFyc5JmKHu2nYTZUtBa145Lof+8/MaQwA6mPaqkyAxVG4WLzZuQSjYO+5sJ9ujBxEHFBd7cXHRLCk5LxQPc8w9ww1PpeLgUPNz/WxjWns1LO+kkIU2k++BRul/rgCKSRiBjEfM7+UpAL33x0PkhoYsaQ6+NNK6INVoJ46oZExPb28SLAJNTmA+nnE5UvFcUBySio7GWAyp03X0rSkQpawPTpMaJcz+wHTmNMy3OCWqUUku1xElMNIdwmevdTZAmAb5dYGuyL6c0s3pjUG5A+zolZxMHlcwOYdnpqPMa8M+SyEdcuiwCw9yHd6XqhnkI4H2KREFfUt9P8ZCbU3IAQB X-Forefront-PRVS: 07658B8EA3 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(6009001)(189002)(24454002)(479174004)(377454003)(40764003)(199003)(52034003)(80316001)(90282001)(4001350100001)(189998001)(87976001)(5007970100001)(92566002)(50466002)(5001770100001)(5004730100002)(2950100001)(76176999)(3846002)(81156007)(64126003)(83506001)(65816999)(586003)(101416001)(97736004)(54356999)(107886002)(6116002)(50986999)(5008740100001)(77096005)(59896002)(122386002)(230700001)(105586002)(88552001)(47776003)(65806001)(5001960100002)(36756003)(40100003)(23746002)(89122001)(42186005)(75432002)(33656002)(87266999)(66066001)(106356001)(65956001);DIR:OUT;SFP:1102;SCL:1;SRVR:BN3PR0301MB0900;H:palken-co-ll.ngdc.noaa.gov;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; Received-SPF: None (protection.outlook.com: colorado.edu does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;BN3PR0301MB0900;23:r9uj6M3U5aIYHO1C+5P255NgMyYlsN00e4R?= =?Windows-1252?Q?wvenm6YedyrIUTKRGMoXPq59fdlU40UAmzkWSAcwATkYnyk+wDLCOP0c?= =?Windows-1252?Q?KfgFjbn3e1VOHQsv/78kwVjZK5LV2YfhpYY7J7wB0qbouXkzo+qPAhoh?= =?Windows-1252?Q?koZWYmi0TFiqm/4CtFRZMp9WfOxlS/p5vHxL/y8Vxvou0OWi/Q8M2YwH?= =?Windows-1252?Q?eS/OTQ1NYmAINqfBnyEfC2WTqb+b++ArzJmXLRBqOFtzw6KKMmJ80Cfw?= =?Windows-1252?Q?EG1x4Q9+GTwNFdEwdXgIZFgoyMKcPL56UXMcJrvJ1GpZbA3ftoCJWlZ/?= =?Windows-1252?Q?Z2I87sAb+TufRj0JuxC3xtw8CL95KzxuwmrldR4D5aqa1rkF8s1G3Lxu?= =?Windows-1252?Q?zhcyhSilmBy8FYKnKJCbluVdYszDysaKMvuy1MamqbFetjwZHrd/0G2j?= =?Windows-1252?Q?2dJfq/Zr6tS/MbG0PLJoRCETk8XlEmWanSSZ6QzDRSg4qlg5Oh9TJtlT?= =?Windows-1252?Q?AoSz4fvbTpPhtGV0zNt2Yvf5xRFB5vo+7moVRGkw9YTlCXTY3GcCCFMh?= =?Windows-1252?Q?wSYVwUDICxjHI/yANiDQfAsRF3ghOeBZbvaskFWmvWjrKiwDkk5YTFcY?= =?Windows-1252?Q?jsyibUNQY38C6F8wjjyOzPqOLSi5TFO3j3sN1cWOQ2r85AHrdZoq8VYj?= =?Windows-1252?Q?hvMNrgXAp2boK4m95iUAYejE1Y5Ctqfpb9YjNHmjGL3+1Q4u7KgJFG+X?= =?Windows-1252?Q?m8zlQX40IEcI3ShmpzKqts5tYlDBSM+nOGXDxrxHNN3S03zNCdUi0az6?= =?Windows-1252?Q?kaiHo6+zgP1qnQ6WC96cztYQaRYgyOmd9OZi3ZRu7zKCEws0iOKneRDh?= =?Windows-1252?Q?DuNcSGjEs9zjQ+nlUQ0ZlfOsBMb2eiJqVp5/pCxudTYvdx9A9xWgtPaJ?= =?Windows-1252?Q?oa+tD+8o0+cXTWQOhqD/rgDOUnoRmvXwRz6exDGXzMdTwbzGQNPQZ5ZW?= =?Windows-1252?Q?sWaQsfVQANYVZ+diCC0Bm8ThTPwW3vZlkGZarLBDGpB/likSNUSZs5RQ?= =?Windows-1252?Q?XMYF9L2xbpa1leJmNEfzGlkVpy7Ln4lrYvv6k+dLYXr/sCHudiilZjQe?= =?Windows-1252?Q?kW1J4Du6GxlIYRNeoWdLb4hL/zwe1IQiszq0VCPOZ0CpdJeOQIbOaffj?= =?Windows-1252?Q?ry4hyUui6d0dyXxNtwHXA4OASnU5A5iyQA/GUI5FEgo/62cW2kdZc3LX?= =?Windows-1252?Q?GNF8dfhdPlauUINE4tA4A4X5zTN0fZV/148k18aSlhL+7BhwMHjR7MN4?= =?Windows-1252?Q?lQbePypg4IbxFPLgjEL+Y3lINuZo81CPcW+MzTf4uqGaDn52kw/VoFJ+?= =?Windows-1252?Q?jcJPaQcuWSSB7+b94rOeHdNWLZhkpK0wUvlWQ35lRYGzonti1ur0Hf4b?= =?Windows-1252?Q?ktmDVxsQ2QFQnsyViPsLKwFXH0WHUh/bR1nvO2UmdSw=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;BN3PR0301MB0900;5:FkRPP4LGIOPqCtszK1yR4Be+AeeeIo2k1KZChzVabSRgjDULYW2bqYBtzXnbsZoavIrybvZu9VGQaEa00rq7GQvekQVC7dFhtdUmAq6dwk1tJcbXlEWbhUwXbaj4kqqBECuVMEvuBuXWXKk7b/vxkw==;24:4PSe9DDslHGPCj+AYoSbVNIosNmVkxh4zltBQnWitnuH5D1xB/VUrinse7YSTZ3tOgJET731ma+bQGgoqnjWYnu3rbWSQqaubgCmx+Sqyp0=;20:9zwxYdYaUGHaclZxfhviQNJmYOVcTElXeuh1lOAdyPkEHyUnZlk9ciabqcxOHQswbtc9CDgu9gidoN50D/p5gg== SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: colorado.edu X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Nov 2015 22:21:11.3119 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR0301MB0900 X-SW-Source: 2015-q4/txt/msg00011.txt.bz2 Hi Bill, Thanks for your help on this. It would be great if you can make a patch to fix this, and I'll have a look. For now you can do an anonymous checkout of the gsl repository and work from there. We typically reserve write access to the git until we have a chance to look at someone's code to make sure its high quality, and also to make sure they're serious about contributing in the future. But in general I'm very grateful to have someone interested in becoming involved. Patrick On 11/17/2015 06:50 PM, Bill Maier wrote: > I've investigated bug #45929 "error in generalized hypergeometric function". The problem is in the > file specfunc/hyperg_2F1.c in the first function the file, hyperg_2F1_series(). There is a loop starting > at line 59 which is intended to converge to the solution, and within this loop is a check to insure the > loop is not executed more than 30000 times. This code is actually working and computing the correct > value, but the error terms del_pos and del_neg eventually get no smaller and so the loop executes the > full 30000 iterations and then reports GSL_EMAXITER error, even though it does have the correct > value calculated. > > I would fix this by saving the previous error terms and insuring they are becoming smaller with each > iteration. If they are not getting smaller, machine precision has been reached and the value can be > returned to the user. I can supply code or could check in myself through git if I can get access. I have > 30+ years of experience with C code and want to begin helping maintain GSL. > > By the way, when I do a git clone to get the code and then run ./autogen, it fails with message > "autoreconf: not found". Has this file been left out of the git repository? > > -Bill Maier