public inbox for gsl-discuss@sourceware.org
 help / color / mirror / Atom feed
From: Patrick Alken <alken@colorado.edu>
To: <gsl-discuss@sourceware.org>
Subject: Re: Sparse matrix extension
Date: Mon, 15 Feb 2016 17:17:00 -0000	[thread overview]
Message-ID: <56C2080A.2030407@colorado.edu> (raw)
In-Reply-To: <CAMWWPT08uPGzje-NU6Mt9gkEFbtaK=xxRA2r0Ee+_EvhuwfH_g@mail.gmail.com>

On 02/15/2016 06:56 AM, Alexis Tantet wrote:
> Thanks Patrick.
> I've had a quick check at your modifications and all the tests pass.
>
> Some very minor details:
> - I find _transpose2 an inexpressive name. What about something like
> _transpose_shallow or _transpose_swap.

Well, many routines the linear algebra section append a "2" when the 
routine does the same thing but using a different method/algorithm, so I 
was trying to be consistent with the naming, and I tried to document 
this routine thoroughly in the manual. I will think some more about 
whether it would make sense to make a longer descriptive name.

> - Regarding _set, wouldn't it be more secure to raise an error when
> the matrix dimensions have to be increased? Do you know of
> applications in which the matrix dimensions are not known beforehand?

This was originally done since the code was based on the CSparse 
library, which did the same thing. You're probably right it makes sense 
to do more strict checking...although this code has been through a few 
releases so people's programs might break if we change the behavior now.

>
> All the best,
> Alexis
>
>> On Mon, Feb 15, 2016 at 12:09 PM, Brian Gladman <brg@gladman.plus.com> wrote:
>>> On 15/02/2016 05:10, Patrick Alken wrote:
>>>> I think the problem should be fixed now, can you test the latest git and
>>>> let me know?
>>> Thanks Patrick,
>>>
>>> Yes, all tests now pass.
>>>
>>>     Brian
>>>
>>
>>
>> --
>> Alexis Tantet

      reply	other threads:[~2016-02-15 17:17 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CAMWWPT3uJj4Vrn7ut6+F18gY===zd6+1r1UJhz0hcCj--zwtdg@mail.gmail.com>
2016-01-19 16:43 ` Alexis Tantet
2016-01-19 17:02   ` Patrick Alken
2016-01-19 19:55     ` Alexis Tantet
2016-01-19 20:50       ` Patrick Alken
2016-01-20 18:31         ` Alexis Tantet
2016-02-07  0:03           ` Patrick Alken
2016-02-07  1:03             ` Alexis Tantet
2016-02-07 17:25               ` Patrick Alken
2016-02-07 19:32                 ` Alexis Tantet
2016-02-07 20:14                   ` Patrick Alken
2016-02-07 20:31                     ` Alexis Tantet
2016-02-07 21:34                       ` Patrick Alken
2016-02-08  0:59                         ` Alexis Tantet
2016-02-10 13:16                           ` Alexis Tantet
2016-02-10 13:48                             ` Alexis Tantet
2016-02-10 15:56                             ` Patrick Alken
2016-02-12 10:43                               ` Alexis Tantet
2016-02-13 19:42                                 ` Patrick Alken
2016-02-14 11:06                                   ` Alexis Tantet
2016-02-14 18:11                                     ` Patrick Alken
2016-02-14 18:25                                       ` Brian Gladman
2016-02-15  5:10                                         ` Patrick Alken
2016-02-15 11:09                                           ` Brian Gladman
     [not found]                                             ` <CAMWWPT0J9ENRZjJHLO=cxot4DGdSLer+n2HkBVnhFnO0oiVV8g@mail.gmail.com>
2016-02-15 13:56                                               ` Alexis Tantet
2016-02-15 17:17                                                 ` Patrick Alken [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56C2080A.2030407@colorado.edu \
    --to=alken@colorado.edu \
    --cc=gsl-discuss@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).