From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 110320 invoked by alias); 15 Feb 2016 17:17:09 -0000 Mailing-List: contact gsl-discuss-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gsl-discuss-owner@sourceware.org Received: (qmail 110298 invoked by uid 89); 15 Feb 2016 17:17:07 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=peoples, people's, HTo:U*gsl-discuss, secure X-HELO: na01-bn1-obe.outbound.protection.outlook.com Received: from mail-bn1on0134.outbound.protection.outlook.com (HELO na01-bn1-obe.outbound.protection.outlook.com) (157.56.110.134) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA256 encrypted) ESMTPS; Mon, 15 Feb 2016 17:17:06 +0000 Authentication-Results: sourceware.org; dkim=none (message not signed) header.d=none;sourceware.org; dmarc=none action=none header.from=colorado.edu; Received: from palken-co-ll.ngdc.noaa.gov (140.172.179.43) by DM2PR0301MB0912.namprd03.prod.outlook.com (10.160.217.142) with Microsoft SMTP Server (TLS) id 15.1.403.16; Mon, 15 Feb 2016 17:17:03 +0000 Subject: Re: Sparse matrix extension To: References: <56B77E13.1000306@colorado.edu> <56B7A59D.5040707@colorado.edu> <56B7B85C.10508@colorado.edu> <56BB5D84.20804@colorado.edu> <56BF86FC.8010509@colorado.edu> <56C0C326.8090701@colorado.edu> <56C0C69D.1070700@gladman.plus.com> <56C15DC9.8060708@colorado.edu> <56C1B1D0.9000303@gladman.plus.com> From: Patrick Alken Message-ID: <56C2080A.2030407@colorado.edu> Date: Mon, 15 Feb 2016 17:17:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: BLUPR0601CA0024.namprd06.prod.outlook.com (25.163.210.34) To DM2PR0301MB0912.namprd03.prod.outlook.com (25.160.217.142) X-MS-Office365-Filtering-Correlation-Id: 5657fd39-eb00-444b-0bac-08d3362bd287 X-Microsoft-Exchange-Diagnostics: 1;DM2PR0301MB0912;2:ujrbIAV6/pFbudie3F36TdQfCGVLlnkCNjFEfaBTn+fZo3aFuxm1ExcpE8IQhxAIKMWVY/kjFLpcmzI1hRjUOzjnJyoQNY6CBxaVVf9md0WPsafVv6puYrXfdTcM0NFg7rSofs+eZMV+MXlC5BJ4d0p51GVTxIasnMTwyX3aXLWjRHYY0RT7VVwjkdYPZxWR;3:K060K/lXszR6m1HwM+5qHA9RbjgGM/fqmJ9tz5wMj2P++XhBYgOUed7A6adTfjR4iMGD+/Qv10rCLcHiO4Q2dUx7XZkPs2KAZsLrsGyECOTfBNqPI09o5eDBfs0zS4zK;25:3dD4eJejuwYHRqgXlIo6QcRDDPqnpQcXR2U/+bhqC2zqK4/QupwCaCBCMCCIejG6QcActMhD0yfYQPt3aEA6RLfxx43147VXC3idMWYDB/aiL33w1+7gBAgtk8XnvPckWmiDr4DzeIzzXo9egigWO7VIRHgqcfRW/8mwTa1/fweSNThi31EY/KHODWs7Bdr7Dh5gnCLCZksZnjgKNiqstEeuOmwKkvMiQEjve1Mzs9Zzm4qzatDcNI3KjKi2fBaYZ8T/+e6Jt05t4rugCDM/q1ldP1uNZcjVAG9ly6uTWTVok+853tNlfGMaVyXq4jqY X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DM2PR0301MB0912; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046);SRVR:DM2PR0301MB0912;BCL:0;PCL:0;RULEID:;SRVR:DM2PR0301MB0912; X-Microsoft-Exchange-Diagnostics: 1;DM2PR0301MB0912;4:YbUj1kswKtaSr/laq6Kk6UbbRvvtQMlRs4n3tJjq9zY/KhdKvyWLmKErxzz2KFMCcjyMVczRQvHXqI62JWhkwY1DwlBfiiXC5JHkni1DlZ6/pSy8tFE2bPVXURmoesuDPQpsgUNqVAfym6FJRmaF41j/YZa+hw7Gc0JSrr6HSSQJsTB3V+5w8VVbUxqqBevmLZ2jRSrPrFdG0peptC3Or3WFUjCzN5jUUtCkRNQ+1BvlJJ2+KFbYfccU/XMPsEmx/l6D1wzCFANjfnf0G3G7QXDRgyB0mNKQAJGNYN+Z22IBwaJwRlbJ7n0uodoFrV4vyzjhsmjhLAn3Bdvcc1UZVtTjZbwA8UYBbSI32OtGbDhO+iiUp8/PRqbMNU+KZigM X-Forefront-PRVS: 08534B37A7 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(377454003)(479174004)(24454002)(122386002)(83506001)(80316001)(5004730100002)(50466002)(75432002)(36756003)(19580395003)(50986999)(76176999)(93886004)(90282001)(2351001)(89122001)(65816999)(33656002)(54356999)(5008740100001)(40100003)(87266999)(19580405001)(450100001)(87976001)(92566002)(66066001)(65956001)(65806001)(77096005)(23676002)(110136002)(107886002)(5001960100002)(189998001)(586003)(42186005)(6116002)(2906002)(3480700003)(230700001)(1096002)(4001350100001)(88552002)(3846002);DIR:OUT;SFP:1102;SCL:1;SRVR:DM2PR0301MB0912;H:palken-co-ll.ngdc.noaa.gov;FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtETTJQUjAzMDFNQjA5MTI7MjM6dVBiNTMxWm1DbFQyNWhiRndobUptYTQy?= =?utf-8?B?ZmtrcnlQd2N0V2cwVU5rVzlhdWc4TDdteTNtYUxWTkVib2M4M21VZzNhWUZj?= =?utf-8?B?dGU0SC8xRFQ5c3JDQjFDMzcrOEIxRHppTGVXY1RPWjVoV1dPVjZWa01kakpw?= =?utf-8?B?NHlzdVRqMENGMlJxMWVhQWZVN0FwT1QydzI4MmtQb0ZJTnRMamNxTVlCZGxa?= =?utf-8?B?cUpOa01QYjhQQVVIMXg3MGJQaWl0MWJzQWIyaU5GdEttdGMzRzQ5YXZDQ2o2?= =?utf-8?B?OFMzUnpDOFoyaytmOEdDbVJzeFFJcEZ1R0xIc2tJa0hLQVg2R2M5cGlqVUU2?= =?utf-8?B?UjRLOFNMbExlWmRBWmZ3MUY5UXJmR0FHZ09PQjJxeGdTcTlnbm1sbFN5TVNS?= =?utf-8?B?Tm9pZDl4WTRNTTdqVE9iRnN5eVBRYkpoNGJEdjBnL1lxSGdsRlpkNzRjb21B?= =?utf-8?B?b3IwQ05FZ3lGT3lPUTZ2b1FDQkh1ejRVTlpoTDR6R3d2aWRyMVE0TFlPTUZk?= =?utf-8?B?amxjdk5SaTgvQ0VkbW9qZnF4NnFBR0ljcXNtSmtlOG82S2tETDhUTnB4NldP?= =?utf-8?B?MDh6a0VkSWNXUmJqU2txVGsvN0VucVNMeGRiRFF0N0NxSHBXcXZzeXR4ODhl?= =?utf-8?B?MnNkUThETjdDY1ZqdDMxLzNXZFBONnliY2VSQUhYdXFTQ05MMnBWRWY0bzZP?= =?utf-8?B?Yk51Z1dCeG40c2R4OXR6RGJvaitra2FnbHFETXpLYjBTZjkzc1d6MUNxMGdt?= =?utf-8?B?ajVlUlk1eXpOb2RCdlB3YmlaNlFPWEx0c2oxT3VrK290aG9NTnJLeFQ3RFJU?= =?utf-8?B?bWg3MlRsLzNjN0hUTHBXYVVaa2E0VEJFRUFTSk8rTTJyRlJaNEQ4Vm0wcDJI?= =?utf-8?B?U2pXa2R4LzI5enQvSXdtVXpuaVoxNTNYRFlGVTlNcGs4K2wyWG9FdEN6V1p5?= =?utf-8?B?aHZHMkM3UXRwS2tSQlNPMHVmY2JLMXd0a1RnOURyeU5qaUtoTm5QaW1JTkZZ?= =?utf-8?B?MWV3SXFRbVpIWGFKQVNqUGc2Z2NHckZNbDFMWlRtZklQUXdhZ3BkWVVxS0FL?= =?utf-8?B?ZE1hT3ZiNjRjSEIwcUJNbHlOdjdIOFVOVXhmY0o5elJ2N25KM1AwZlhSRzVw?= =?utf-8?B?Vk5PMGx6U3g5SVZGR2p5ckphMnlhdlkzTEIxQ2dTaEp5TWxNMDc2bHduZWxJ?= =?utf-8?B?NW04MVBXVGhTSWFxY0tRTlR4SUJmQzVZc3pPYlVRTVl5TXhqVUF4TWhtcTdz?= =?utf-8?B?MU12ekdaN1ZzR1UrYnlReE82WnZKa1NsdlhhaW9VOVd4bVRVeUhxaGxveERB?= =?utf-8?B?RFd2dk50MW1zWUlDeEhSNWxLT2J3eUN6RHJRMDlvb08vQWRUVW8vQUxDRnVi?= =?utf-8?B?TS9nUEVESERJU1Rmb0h5VXlHaFMzZUs0bVpkdlBJYUpTQWp3a1h0aUJmUWQ4?= =?utf-8?B?SXlWaGYzV21ZQytpYUpPL0N2dHZXc09vM0JXUW1Tb0l3dVZXdGVGVTBDV2k2?= =?utf-8?B?d3AzeTY5cFhWYytpTXF1dW5SVTlUUUFxVUwrVG5HL1ZXc3FoaDF3TGN1bUN2?= =?utf-8?B?ai9wVFMyVS9DUkxLUG9wTlplS3RSRGFGb3N6UjlyZ0gwT0lNV2RPczdENTVW?= =?utf-8?B?WWk2Mk1uZTZtcFdPdlBGeUE3VUZyaFhMYnYyc3lCLy9aWFVjQnoyM0dmaDUw?= =?utf-8?Q?mRG8lijBo41PAB97PVtY=3D?= X-Microsoft-Exchange-Diagnostics: 1;DM2PR0301MB0912;5:yUlOdFYsFUBPKn535dTJQXtDEUe8y08TV3dvpuT0dQ7HciZggraVHFhlT0xvdsJR9nzmYTneRCsm6+TSIAIXehrrMDjxPFCkRjJsWxWE6j3dNUUait+n108IeHt/JGT+dW/eNqg9Kd09F9LMvxBPPg==;24:TkxczAzEz3jfxZXP0u3IsjWZvSgOrw4yEPC6NI602BKrXfQfo9bnQ5kDTsFslu29FqfSDhOOKD8er8StouXxTUuPy3wnoYRCbhPS0kuJxuY= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: colorado.edu X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2016 17:17:03.0431 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM2PR0301MB0912 X-SW-Source: 2016-q1/txt/msg00024.txt.bz2 On 02/15/2016 06:56 AM, Alexis Tantet wrote: > Thanks Patrick. > I've had a quick check at your modifications and all the tests pass. > > Some very minor details: > - I find _transpose2 an inexpressive name. What about something like > _transpose_shallow or _transpose_swap. Well, many routines the linear algebra section append a "2" when the routine does the same thing but using a different method/algorithm, so I was trying to be consistent with the naming, and I tried to document this routine thoroughly in the manual. I will think some more about whether it would make sense to make a longer descriptive name. > - Regarding _set, wouldn't it be more secure to raise an error when > the matrix dimensions have to be increased? Do you know of > applications in which the matrix dimensions are not known beforehand? This was originally done since the code was based on the CSparse library, which did the same thing. You're probably right it makes sense to do more strict checking...although this code has been through a few releases so people's programs might break if we change the behavior now. > > All the best, > Alexis > >> On Mon, Feb 15, 2016 at 12:09 PM, Brian Gladman wrote: >>> On 15/02/2016 05:10, Patrick Alken wrote: >>>> I think the problem should be fixed now, can you test the latest git and >>>> let me know? >>> Thanks Patrick, >>> >>> Yes, all tests now pass. >>> >>> Brian >>> >> >> >> -- >> Alexis Tantet