public inbox for gsl-discuss@sourceware.org
 help / color / mirror / Atom feed
From: <keith.briggs@bt.com>
To: <gsl-discuss@sourceware.org>
Subject: RE: Not clear to understand :)
Date: Thu, 22 Nov 2007 11:40:00 -0000	[thread overview]
Message-ID: <6546343904687E41B19D8E5A26AB9F530175DA0C@E03MVB2-UKBR.domain1.systemhost.net> (raw)
In-Reply-To: <1195731261.5477.14.camel@localhost.localdomain>

These are *not* equivalent in floating point, of course.  The first is better.   
Even better:

  for (i = 1; i <= n; i++)
    {
      m_x += (x[i * xstride] - m_x) / i;
      m_y += (y[i * ystride] - m_y) / i;
    }

Keith

-----Original Message-----
From: gsl-discuss-owner@sourceware.org
[mailto:gsl-discuss-owner@sourceware.org]On Behalf Of Serhiy Lisovenko
Sent: 22 November 2007 11:34
To: gsl-discuss@sourceware.org
Subject: Not clear to understand :)


in file fit/linear.c

  for (i = 0; i < n; i++)
    {
      m_x += (x[i * xstride] - m_x) / (i + 1.0);
      m_y += (y[i * ystride] - m_y) / (i + 1.0);
    }

and other same...

code equivalent to

  for (i = 0; i < n; i++)
    {
      m_x +=x[i * xstride];
      m_y +=y[i * ystride];
    }
m_x/=(double)n;
m_y/=(double)n;

But the second code is more clear and some faster (no extra divisions).




  reply	other threads:[~2007-11-22 11:40 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-22 11:33 Serhiy Lisovenko
2007-11-22 11:40 ` keith.briggs [this message]
2007-11-22 16:13 ` Patrick Alken

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6546343904687E41B19D8E5A26AB9F530175DA0C@E03MVB2-UKBR.domain1.systemhost.net \
    --to=keith.briggs@bt.com \
    --cc=gsl-discuss@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).