From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6284 invoked by alias); 12 Sep 2007 21:02:05 -0000 Received: (qmail 6276 invoked by uid 22791); 12 Sep 2007 21:02:04 -0000 X-Spam-Check-By: sourceware.org Received: from ch-smtp02.sth.basefarm.net (HELO ch-smtp02.sth.basefarm.net) (80.76.149.213) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 12 Sep 2007 21:01:58 +0000 Received: from c213-89-101-39.bredband.comhem.se ([213.89.101.39]:33554 helo=[192.168.0.2]) by ch-smtp02.sth.basefarm.net with esmtp (Exim 4.66) (envelope-from ) id 1IVZLO-0000nQ-7L; Wed, 12 Sep 2007 23:01:56 +0200 In-Reply-To: <87bqc9rmzg.fsf@hotbox.ru> References: <87bqc9rmzg.fsf@hotbox.ru> Mime-Version: 1.0 (Apple Message framework v752.2) Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-Id: <682A4679-3C95-4DE0-AC92-BF1B57A241B2@comhem.se> Cc: Brian Gough , gsl-discuss@sourceware.org Content-Transfer-Encoding: 7bit From: Tommy Nordgren Subject: Re: test release gsl-1.9.90.tar.gz Date: Wed, 12 Sep 2007 21:02:00 -0000 To: Aleksej Saushev X-Mailer: Apple Mail (2.752.2) X-Scan-Result: No virus found in message 1IVZLO-0000nQ-7L. Mailing-List: contact gsl-discuss-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gsl-discuss-owner@sourceware.org X-SW-Source: 2007-q3/txt/msg00027.txt.bz2 On 11 sep 2007, at 22.00, Aleksej Saushev wrote: > Brian Gough writes: > >> I have made a test release for gsl-1.10. > > gcc -DHAVE_CONFIG_H -I. -I.. -I.. -g -O2 -c test.c > /bin/ksh ../libtool --tag=CC --mode=link gcc -g -O2 -o test > test.o libgslsys.la ../ieee-utils/libgslieeeutils.la ../err/ > libgslerr.la ../test/libgsltest.la libgslsys.la ../utils/ > libutils.la -lm > gcc -g -O2 -o test test.o ../ieee-utils/.libs/libgslieeeutils.a ../ > err/.libs/libgslerr.a ../test/.libs/libgsltest.a ./.libs/ > libgslsys.a ../utils/.libs/libutils.a -lm > make check-TESTS > FAIL: gsl_isinf(-inf) (1 observed vs -1 expected) [112] > FAIL: test > =================== > 1 of 1 tests failed > =================== > > Fix attached. > > NetBSD 4.99.31 i386 > cc (GCC) 4.1.3 20070620 prerelease (NetBSD nb1 20070620) > > With fix all tests pass. > > --- sys/test.c.orig 2007-06-11 12:57:34.000000000 +0400 > +++ sys/test.c 2007-06-11 12:57:52.000000000 +0400 > @@ -383,7 +383,7 @@ > negative). (This is all that C99 requires.) */ > > s = gsl_isinf (-inf); > - gsl_test_int (s, -1, "gsl_isinf(-inf)"); > + gsl_test_int (s, 1, "gsl_isinf(-inf)"); > > s = gsl_isinf (nan); > gsl_test_int (s, 0, "gsl_isinf(nan)"); The following alternate patch will fix the test failure, without modifying the test cases. --- /Users/emac/Desktop/infnan.c 2007-09-12 22:37:19.000000000 +0200 +++ /Softsys/gsl-1.9.90/sys/infnan.c 2007-09-12 22:44:30.000000000 +0200 @@ -118,7 +118,11 @@ int gsl_isinf (const double x) { - return isinf(x); + int result = isinf(x); + if (result > 0 && x < 0) { + result = - result; + } + return result; } # else Note: the one on the desktop is the unmodified file. Also, with make -k check all other test cases pass. ------------------------------------- This sig is dedicated to the advancement of Nuclear Power Tommy Nordgren tommy.nordgren@comhem.se