From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 96227 invoked by alias); 20 Nov 2015 15:54:48 -0000 Mailing-List: contact gsl-discuss-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gsl-discuss-owner@sourceware.org Received: (qmail 96214 invoked by uid 89); 20 Nov 2015 15:54:46 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_05,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: BAY004-OMC1S21.hotmail.com Received: from bay004-omc1s21.hotmail.com (HELO BAY004-OMC1S21.hotmail.com) (65.54.190.32) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA256 encrypted) ESMTPS; Fri, 20 Nov 2015 15:54:45 +0000 Received: from BAY176-W37 ([65.54.190.61]) by BAY004-OMC1S21.hotmail.com over TLS secured channel with Microsoft SMTPSVC(7.5.7601.23008); Fri, 20 Nov 2015 07:54:44 -0800 X-TMN: [R6YGv4JvBqrx39DupHB7sSsH8OU3dpgc] Message-ID: From: Bill Maier To: "gsl-discuss@sourceware.org" Subject: RE: Bug #45926 Date: Fri, 20 Nov 2015 15:54:00 -0000 In-Reply-To: <564E4B52.5040105@colorado.edu> References: ,<564E4B52.5040105@colorado.edu> Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-SW-Source: 2015-q4/txt/msg00012.txt.bz2 I understand about keeping the repository safe. I'll just send a gzipped ta= r file to your email address with the code changes for you to copy into you= r sandbox. I've been playing with this for a couple of days now and I belie= ve the issue is fixed without any side effects. Besides the code change I a= lso added a couple of tests to try out the changes. -Bill ---------------------------------------- > Subject: Re: Bug #45926 > To: gsl-discuss@sourceware.org; shufflesky@hotmail.com > From: alken@colorado.edu > Date: Thu, 19 Nov 2015 15:21:06 -0700 > > Hi Bill, > > Thanks for your help on this. It would be great if you can make a > patch to fix this, and I'll have a look. For now you can do an anonymous > checkout of the gsl repository and work from there. We typically reserve > write access to the git until we have a chance to look at someone's code > to make sure its high quality, and also to make sure they're serious > about contributing in the future. But in general I'm very grateful to > have someone interested in becoming involved. > > Patrick > > On 11/17/2015 06:50 PM, Bill Maier wrote: >> I've investigated bug #45929 "error in generalized hypergeometric functi= on". The problem is in the >> file specfunc/hyperg_2F1.c in the first function the file, hyperg_2F1_se= ries(). There is a loop starting >> at line 59 which is intended to converge to the solution, and within thi= s loop is a check to insure the >> loop is not executed more than 30000 times. This code is actually workin= g and computing the correct >> value, but the error terms del_pos and del_neg eventually get no smaller= and so the loop executes the >> full 30000 iterations and then reports GSL_EMAXITER error, even though i= t does have the correct >> value calculated. >> >> I would fix this by saving the previous error terms and insuring they ar= e becoming smaller with each >> iteration. If they are not getting smaller, machine precision has been r= eached and the value can be >> returned to the user. I can supply code or could check in myself through= git if I can get access. I have >> 30+ years of experience with C code and want to begin helping maintain G= SL. >> >> By the way, when I do a git clone to get the code and then run ./autogen= , it fails with message >> "autoreconf: not found". Has this file been left out of the git reposito= ry? >> >> -Bill Maier > =20=09=09=20=09=20=20=20=09=09=20=20