From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 98826 invoked by alias); 15 Feb 2016 13:56:34 -0000 Mailing-List: contact gsl-discuss-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gsl-discuss-owner@sourceware.org Received: (qmail 98811 invoked by uid 89); 15 Feb 2016 13:56:33 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=dimensions, secure, H*Ad:U*gsl-discuss X-HELO: mail-io0-f173.google.com Received: from mail-io0-f173.google.com (HELO mail-io0-f173.google.com) (209.85.223.173) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Mon, 15 Feb 2016 13:56:32 +0000 Received: by mail-io0-f173.google.com with SMTP id 9so160253459iom.1 for ; Mon, 15 Feb 2016 05:56:32 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=b5+WJr5DbaAAro7466LA+Gpp4EehBZiLRRFVZNEuoiA=; b=mBiTOyFlW037q9LhEtlApqHKb/AVfqphRBVLTIyzZvdHDKoXIveQ/fAY3FyCzn16yi EQgjc0DHhQM8YQIkzOd4xGTSJS5Jzl14BQMN+p4MHiFPL8VyuA7eSpkQesxNLuRIDL+B 0uXjy6nGaT0Rrx3NRSc1fxd4JJfIJKT5HlV6MEntrXwyFGf/HIWO5P3GH7tvQ5tWVv3W X/ksCo6/f1qPq4Z0Fp8EMFii9yCcPyD7pnwkS2dkLnoLhHJlb18OyA1EmfjhuANt5OYh afNWT8SvyiekJ+7EruCD4K8kn2jRzD/N5G0CIkhmIXmKJlKzyM4N25btBeWw6WjHAtb6 bkSA== X-Gm-Message-State: AG10YORel6QozsJLLQXtivAANJhBnWg+23YEizW3lR/H2YWVvGBZZf4p8i84LD8kQUQwRzxr4pjgnYLy3eEA6Q== MIME-Version: 1.0 X-Received: by 10.107.19.213 with SMTP id 82mr11164544iot.6.1455544590393; Mon, 15 Feb 2016 05:56:30 -0800 (PST) Received: by 10.79.118.141 with HTTP; Mon, 15 Feb 2016 05:56:30 -0800 (PST) In-Reply-To: References: <569EA1A9.2080101@colorado.edu> <56B689B1.5090005@colorado.edu> <56B77E13.1000306@colorado.edu> <56B7A59D.5040707@colorado.edu> <56B7B85C.10508@colorado.edu> <56BB5D84.20804@colorado.edu> <56BF86FC.8010509@colorado.edu> <56C0C326.8090701@colorado.edu> <56C0C69D.1070700@gladman.plus.com> <56C15DC9.8060708@colorado.edu> <56C1B1D0.9000303@gladman.plus.com> Date: Mon, 15 Feb 2016 13:56:00 -0000 Message-ID: Subject: Re: Sparse matrix extension From: Alexis Tantet To: Brian Gladman Cc: gsl-discuss@sourceware.org Content-Type: text/plain; charset=UTF-8 X-SW-Source: 2016-q1/txt/msg00023.txt.bz2 Thanks Patrick. I've had a quick check at your modifications and all the tests pass. Some very minor details: - I find _transpose2 an inexpressive name. What about something like _transpose_shallow or _transpose_swap. - Regarding _set, wouldn't it be more secure to raise an error when the matrix dimensions have to be increased? Do you know of applications in which the matrix dimensions are not known beforehand? All the best, Alexis > On Mon, Feb 15, 2016 at 12:09 PM, Brian Gladman wrote: >> >> On 15/02/2016 05:10, Patrick Alken wrote: >> > I think the problem should be fixed now, can you test the latest git and >> > let me know? >> >> Thanks Patrick, >> >> Yes, all tests now pass. >> >> Brian >> > > > > -- > Alexis Tantet