From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gsl-discuss-return-5399-listarch-gsl-discuss=sources.redhat.com@sourceware.org>
Received: (qmail 19020 invoked by alias); 1 Feb 2009 17:01:14 -0000
Received: (qmail 18605 invoked by uid 22791); 1 Feb 2009 17:01:13 -0000
X-SWARE-Spam-Status: No, hits=-1.8 required=5.0
	tests=AWL,BAYES_00,SPF_PASS
X-Spam-Check-By: sourceware.org
Received: from mail.network-theory.co.uk (HELO mail.network-theory.co.uk) (66.199.228.187)
    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 01 Feb 2009 17:01:08 +0000
Date: Sun, 01 Feb 2009 17:01:00 -0000
Message-ID: <m38woqp3je.wl%bjg@network-theory.co.uk>
From: Brian Gough <bjg@gnu.org>
To: Tuomo Keskitalo <Tuomo.Keskitalo@iki.fi>
Cc: GSL Discuss Mailing List <gsl-discuss@sourceware.org>
Subject: Re: ode-initval implicit solvers and development
In-Reply-To: <497B00F6.2080400@iki.fi>
References: <48E25CA9.6080306@iki.fi>
	<490DE4BD.7070907@iki.fi>
	<m3y700znqd.wl%bjg@network-theory.co.uk>
	<497B00F6.2080400@iki.fi>
User-Agent: Wanderlust/2.14.0 (Africa) Emacs/22.2 Mule/5.0 (SAKAKI)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
X-Message-Mac: b9e5b1194fb3f4788974042d078adf8c
Mailing-List: contact gsl-discuss-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gsl-discuss.sourceware.org>
List-Subscribe: <mailto:gsl-discuss-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gsl-discuss/>
List-Post: <mailto:gsl-discuss@sourceware.org>
List-Help: <mailto:gsl-discuss-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gsl-discuss-owner@sourceware.org
X-SW-Source: 2009-q1/txt/msg00003.txt.bz2

At Sat, 24 Jan 2009 13:52:22 +0200,
Tuomo Keskitalo wrote:
> Please note the comments on file ode-initval/ChangeLog-Keskitalo. The 
> biggest change is an addition to the step and control object structures 
> to allow passing error tolerance to steppers. I'm afraid a change like 
> this is really needed.

I had a look at the code (which all looks pretty sensible) and have
a couple of questions.

- Currently the control object is only used by the multistep adams
stepper.  What other types of methods might need access to the error
control?

- In modnewton1.c there is the comment

    /* Stopping tolerance for Newton iteration */
    /* FIXME: tol should be user defined */

How would you handle the newton tolerance--do we need a way to pass
that in as well?

Valgrind detects an uninitialised variable in msadams.c, which is
flagged with -Wall as well.


-- 
Brian Gough