From: Brian Gough <bjg@gnu.org>
To: Rhys Ulerich <rhys.ulerich@gmail.com>
Cc: gsl-discuss@sourceware.org
Subject: Re: [PATCH] Adding multiset functionality atop GSL 1.13
Date: Wed, 23 Sep 2009 16:49:00 -0000 [thread overview]
Message-ID: <m3my4lvc9y.wl%bjg@network-theory.co.uk> (raw)
In-Reply-To: <4a00655d0909211838i5a1feacfq9bd4ddcad8f27206@mail.gmail.com>
At Mon, 21 Sep 2009 20:38:31 -0500,
Rhys Ulerich wrote:
> Attached is a patch that adds multiset functionality atop GSL 1.13.
> Multisets are like combinations but with replacement-- a single item
> may appear multiple times. Element order is insignificant and
> enumeration uses lexicographical ordering.
>
> The patch builds very, very, very heavily on the existing combinations
> code. Documentation, an example, and unit tests are included.
> Please consider it for inclusion in the next feature release.
Nice work... I've committed the patch.
> P.S. One weakness in the patch the amount of code duplication relative
> to combinations. The underlying data structures are the same, and
> only the _init_first, _init_last, _valid, _next, and _prev functions
> differ in a non-trivial way. With some thought to naming, multisets
> could be a combinations-with-replacement flag. If you accept the
> patch, please consider adding a TODO to both directories to merge the
> functionality.
Done.
prev parent reply other threads:[~2009-09-23 16:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-22 1:39 Rhys Ulerich
2009-09-23 16:49 ` Brian Gough [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3my4lvc9y.wl%bjg@network-theory.co.uk \
--to=bjg@gnu.org \
--cc=gsl-discuss@sourceware.org \
--cc=rhys.ulerich@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).