From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27779 invoked by alias); 25 Nov 2008 14:52:20 -0000 Received: (qmail 27724 invoked by uid 22791); 25 Nov 2008 14:52:17 -0000 X-Spam-Check-By: sourceware.org Received: from mail.network-theory.co.uk (HELO mail.network-theory.co.uk) (66.199.228.187) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 25 Nov 2008 14:51:38 +0000 Date: Mon, 08 Dec 2008 21:43:00 -0000 Message-ID: From: Brian Gough To: Patrick Alken Cc: gsl-discuss@sourceware.org, Rhys Ulerich Subject: Re: [Help-gsl] Submitted patch to add bspline derivative capabilities In-Reply-To: <20081124175854.GA994@hippogriff.homeunix.org> References: <4a00655d0811191412t371982eev1bb77325719860f7@mail.gmail.com> <20081119235047.GA18604@hippogriff.homeunix.org> <20081124175854.GA994@hippogriff.homeunix.org> User-Agent: Wanderlust/2.14.0 (Africa) Emacs/22.2 Mule/5.0 (SAKAKI) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII X-Message-Mac: 921ff4fcaffdfd57f9e46c4623127b9b Mailing-List: contact gsl-discuss-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gsl-discuss-owner@sourceware.org X-SW-Source: 2008-q4/txt/msg00036.txt.bz2 At Mon, 24 Nov 2008 10:58:54 -0700, Patrick Alken wrote: > > The new code looks clean and very well written. I made a test > program comparing the gsl_bspline_eval_deriv output directly > with PPPACK's bvalue() routine, which is an independent implementation > of bspline derivatives (gsl_bspline_eval_deriv is based on bsplvd()). > > The results look fine. I also ran it through valgrind with good > results. I think it can be put into the next release. Sounds good, please go ahead and commit it to savannah. -- Brian Gough