From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keisuke Nishida To: guile-emacs@sourceware.cygnus.com Subject: Re: patch: M-x emacs-version Date: Tue, 21 Mar 2000 12:18:00 -0000 Message-id: References: <87k8ixftez.fsf@PC486.Niemitalo.LAN> X-SW-Source: 2000-q1/msg00050.html Kalle Olavi Niemitalo writes: > I have patched `features' and `emacs-version' as suggested in > TODO; however, I called the feature `guile-emacs' because `guile' > is already used by guile.scm. (Perhaps modules shouldn't provide > features because Guile already keeps track of them.) Sounds good. I think `guile' is a better name as a feature. We can remove the line "(provide 'guile)" from guile.scm and provide a Lisp function `use-scheme-module' or something. > I didn't format this as a patch to a emacs-20.6.patch because the > header lines ("retrieving revision"...) wouldn't have matched > anyway. Could we keep both original and modified Emacs files in > the package and generate the patch automatically somehow? OK, I did it. Individual files are now available via CVS by typing "cvs update -d". 2000-03-21 Keisuke Nishida * Now the `src' subdirectory contains original emacs source files and our patched version. If we want to make a patch to Emacs, we should do this first: 1. Copy the original file to an appropriate directory. 2. Commit it with the revision 1.1 and the tag `emacs_20_6' (or whatever if the patch is for other than Emacs 20.6). 3. Modify the file as we like and commit it as always. Then we can create a patch by typing this: % cd src/emacs-20.6; cvs diff -c -r emacs_20_6 > emacs-20.6.patch * src/emacs-20.6/lisp/startup.el, src/emacs-20.6/lisp/version.el, src/emacs-20.6/src/Makefile.in, src/emacs-20.6/src/guileapi.c src/emacs-20.6/src/alloc.c, src/emacs-20.6/src/lisp.h src/emacs-20.6/src/emacs.c, src/emacs-20.6/src/print.c: New files. Could you commit your patch by yourself? I'm not sure whether we should include this subdirectory in a archive instead of a patch.