From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31728 invoked by alias); 15 May 2003 23:00:54 -0000 Mailing-List: contact guile-gtk-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: guile-gtk-owner@sources.redhat.com Received: (qmail 31710 invoked from network); 15 May 2003 23:00:52 -0000 Received: from unknown (HELO snoopy.pacific.net.au) (61.8.0.36) by sources.redhat.com with SMTP; 15 May 2003 23:00:52 -0000 Received: from sunny.pacific.net.au (sunny.pacific.net.au [203.2.228.40]) by snoopy.pacific.net.au (8.12.3/8.12.3/Debian-6.3) with ESMTP id h4FN0ZPc021734; Fri, 16 May 2003 09:00:43 +1000 Received: from wisma.pacific.net.au (wisma.pacific.net.au [210.23.129.72]) by sunny.pacific.net.au with ESMTP id h4FN0ZQg009547; Fri, 16 May 2003 09:00:35 +1000 (EST) Received: from localhost (ppp33.dyn228.pacific.net.au [203.143.228.33]) by wisma.pacific.net.au (8.12.9/8.12.9) with ESMTP id h4FN0TYZ024786; Fri, 16 May 2003 09:00:34 +1000 (EST) Received: from gg by localhost with local (Exim 3.35 #1 (Debian)) id 19GRi0-00015K-00; Fri, 16 May 2003 09:00:20 +1000 To: Marko Rauhamaa Cc: guile-gtk@sources.redhat.com Subject: Re: Completed RGB functionality References: From: Kevin Ryde Mail-Copies-To: never Date: Thu, 15 May 2003 23:00:00 -0000 Message-ID: <87bry3iznh.fsf@zip.com.au> User-Agent: Gnus/5.090019 (Oort Gnus v0.19) Emacs/21.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2003-q2/txt/msg00071.txt.bz2 Marko Rauhamaa writes: > > - gdk-1.2.defs: Decided not to implement the function > gdk_rgb_xpixel_from_rgb since it would have no use in scheme code. > Instead, I implemented (gdk-color-new rgb), which calls > gdk_rgb_xpixel_from_rgb to create a new GdkColor. Gdk-color-new has > no C equivalent. I don't think this should be called gdk-color-new, a name like that gives no hint that GdkRGB is being run. I'd suggest gdk-color-new should just create a GdkColor object with zero fields. Field setter functions can be introduced to manipulate them. I think field setters would be good anyway (for gdk_colormap_alloc and friends for instance), and in this case they'd mean a direct gdk_rgb_xpixel_from_rgb was useful. Another thing field setters would do is mean that gdk-color-change can take the same parameters as the C gdk_color_change, ie. a GdkColor containing a pixel value. Unnecessary variations between the C and Scheme functions are not good.