From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 894 invoked by alias); 23 May 2003 22:01:06 -0000 Mailing-List: contact guile-gtk-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: guile-gtk-owner@sources.redhat.com Received: (qmail 865 invoked from network); 23 May 2003 22:01:06 -0000 Received: from unknown (HELO snoopy.pacific.net.au) (61.8.0.36) by sources.redhat.com with SMTP; 23 May 2003 22:01:06 -0000 Received: from sunny.pacific.net.au (sunny.pacific.net.au [203.2.228.40]) by snoopy.pacific.net.au (8.12.3/8.12.3/Debian-6.3) with ESMTP id h4NM11PB020247; Sat, 24 May 2003 08:01:02 +1000 Received: from wisma.pacific.net.au (wisma.pacific.net.au [210.23.129.72]) by sunny.pacific.net.au with ESMTP id h4NM11Qg029366; Sat, 24 May 2003 08:01:01 +1000 (EST) Received: from localhost (ppp126.dyn228.pacific.net.au [203.143.228.126]) by wisma.pacific.net.au (8.12.9/8.12.9) with ESMTP id h4NM0xYZ009057; Sat, 24 May 2003 08:01:00 +1000 (EST) Received: from gg by localhost with local (Exim 3.35 #1 (Debian)) id 19JKar-0000iW-00; Sat, 24 May 2003 08:00:53 +1000 To: Marko Rauhamaa Cc: guile-gtk@sources.redhat.com Subject: Re: Selection and DND completed References: From: Kevin Ryde Mail-Copies-To: never Date: Fri, 23 May 2003 22:01:00 -0000 Message-ID: <87d6i9miga.fsf@zip.com.au> User-Agent: Gnus/5.090019 (Oort Gnus v0.19) Emacs/21.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2003-q2/txt/msg00093.txt.bz2 Marko Rauhamaa writes: > > gdk_selection_property_get_interp > > return length ? scm_take_str (data, length) : SCM_BOOL_F; Not sure if length==0 would be valid data, though I don't see a reason it wouldn't be. It might be nice to return an empty string for that. data==NULL is supposedly the error indication, perhaps that could give the #f. However the 1.2 code looks like it doesn't store anything to data if the window has been destroyed, so it might be prudent to initialize to NULL. It also looks like prop_type and prop_format are not set if the window has been destroyed, maybe they should get initial values to avoid problems too. GDK_NONE and 0 might be enough.