public inbox for guile-gtk@sourceware.org
 help / color / mirror / Atom feed
From: Kevin Ryde <user42@zip.com.au>
To: guile-gtk@sources.redhat.com
Subject: gdk-fontset-load (was: Completed GdkFont support)
Date: Fri, 08 Aug 2003 22:06:00 -0000	[thread overview]
Message-ID: <87llu3dctt.fsf@zip.com.au> (raw)
In-Reply-To: <m3znlwo8x3.fsf@lumo.pacujo.net>

[-- Attachment #1: Type: text/plain, Size: 633 bytes --]

Marko Rauhamaa <marko@pacujo.net> writes:
>
>  - gdk-1.2.defs, gdk-support.c, guile-gtk.h: I allow the fontset name to
>    be either a string or a list of strings, which are joined with
>    commas. The strings themselves may contain commas.

I don't see any great value in that, I think it'd be cleaner to just
take a string, since that's how Gtk treats a fontset.  If someone
wants to use a list instead then I think they can be left to apply
string-join or whatever themselves.

        * gdk-1.2.defs (gdk_fontset_load): Accept only a string, per C func.
        * gdk-support.c, guile-gtk.h (gdk_fontset_load_interp): Remove.


[-- Attachment #2: gdk-1.2.defs.fontset-load.diff --]
[-- Type: text/plain, Size: 442 bytes --]

--- gdk-1.2.defs.~1.42.~	2003-08-05 10:30:19.000000000 +1000
+++ gdk-1.2.defs	2003-08-08 16:19:26.000000000 +1000
@@ -1333,11 +1333,9 @@
   (GdkFont (copy #f))
   ((string name)))
 
-(define-func gdk_fontset_load_interp
+(define-func gdk_fontset_load
   (GdkFont (copy #f))
-  ; fontset is either a comma-separated string or a list of
-  ; comma-separated strings
-  ((SCM fontset)))
+  ((string fontset)))
 
 (define-func gdk_font_id
   int

      parent reply	other threads:[~2003-08-08 22:06 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-05-09  7:58 Completed GdkFont support Marko Rauhamaa
2003-05-12  0:05 ` Kevin Ryde
2003-05-12  0:14   ` Marko Rauhamaa
2003-05-12  7:07   ` Marko Rauhamaa
2003-08-08 22:06 ` Kevin Ryde [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87llu3dctt.fsf@zip.com.au \
    --to=user42@zip.com.au \
    --cc=guile-gtk@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).