From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2863 invoked by alias); 8 Aug 2003 22:43:31 -0000 Mailing-List: contact guile-gtk-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: guile-gtk-owner@sources.redhat.com Received: (qmail 2855 invoked from network); 8 Aug 2003 22:43:30 -0000 Received: from unknown (HELO snoopy.pacific.net.au) (61.8.0.36) by sources.redhat.com with SMTP; 8 Aug 2003 22:43:30 -0000 Received: from sunny.pacific.net.au (sunny.pacific.net.au [203.2.228.40]) by snoopy.pacific.net.au (8.12.3/8.12.3/Debian-6.4) with ESMTP id h78MhS0J023962 for ; Sat, 9 Aug 2003 08:43:28 +1000 Received: from wisma.pacific.net.au (wisma.pacific.net.au [210.23.129.72]) by sunny.pacific.net.au with ESMTP id h78MhRCh011926 for ; Sat, 9 Aug 2003 08:43:27 +1000 (EST) Received: from localhost (ppp24.dyn228.pacific.net.au [203.143.228.24]) by wisma.pacific.net.au (8.12.9/8.12.9) with ESMTP id h78MhQPs010761 for ; Sat, 9 Aug 2003 08:43:27 +1000 (EST) Received: from gg by localhost with local (Exim 3.35 #1 (Debian)) id 19lFx4-0002r9-00; Sat, 09 Aug 2003 08:43:14 +1000 To: guile-gtk@sources.redhat.com Subject: gdk-colormap-alloc-colors From: Kevin Ryde Mail-Copies-To: never Date: Fri, 08 Aug 2003 22:43:00 -0000 Message-ID: <87u18rbwji.fsf@zip.com.au> User-Agent: Gnus/5.090019 (Oort Gnus v0.19) Emacs/21.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2003-q3/txt/msg00033.txt.bz2 I think gdk-colormap-alloc-colors would be better done more in line with the C function, namely returning a count and a list of #t/#f for successes and failures. I also think it should to modify the colour objects it gets to give back the results from that function. The pixel value in particular is the whole point of allocating. * gdk-1.2.defs, gdk-support.c (gdk_colormap_alloc_colors_interp): Rewrite returning failure count and list of #t/#f, per C function. Modify given GdkColor objects with results. Perhaps something in the present style has a place, but if so it really needs to be under under a different name to avoid confusion. I presume the current code has never been run though, since it bombs immediately. (Negatives to scm_done_malloc seem broken, both in guile 1.6 and the cvs).