From: Daniel Skarda <0rfelyus@ucw.cz>
To: guile-gtk@sources.redhat.com
Cc: Kevin Ryde <user42@zip.com.au>
Subject: Re: GtkAdjustment setters
Date: Thu, 02 Jan 2003 23:54:00 -0000 [thread overview]
Message-ID: <m01y3vi0lo.fsf@hobitin.ucw.cz> (raw)
In-Reply-To: <87adioh45k.fsf@zip.com.au> (Kevin Ryde's message of "Mon, 30 Dec 2002 08:05:43 +1000")
Hello,
thank you for your patch - I am going to commit it to CVS in few minutes
(unfortunately I am working offline, so maybe somebody already did it).
There is only one issue I do not like about the patch - it creates a setter
gtk-adjustment-set-value!, while we already have gtk-adjustment-set-value
(without exclamation mark) binding for Gtk function.
Moreover, exclamation marks are not used in guile-gtk at all (so ! in
gtk-adjustment setters could be unwanted surprise to guile-gtk users) - but this
is not problem of your patch but it is more guile-gtk problem.
So I removed *-set-value! setter from your patch in favour of Gtk *-set-value
function.
0.
ps: BTW - it is strange that "setter" feature has not been used. I am afraid which
Gtk features does not have their GuileGtk companions yet... It seems we have to
check it very soon.
prev parent reply other threads:[~2003-01-02 23:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-12-29 14:06 Kevin Ryde
2003-01-02 23:54 ` Daniel Skarda [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m01y3vi0lo.fsf@hobitin.ucw.cz \
--to=0rfelyus@ucw.cz \
--cc=guile-gtk@sources.redhat.com \
--cc=user42@zip.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).