From: Marko Rauhamaa <marko@pacujo.net>
To: guile-gtk@sources.redhat.com
Subject: Re: Selection and DND completed
Date: Fri, 23 May 2003 22:57:00 -0000 [thread overview]
Message-ID: <m3ptm9e0uj.fsf@lumo.pacujo.net> (raw)
In-Reply-To: <87d6i9miga.fsf@zip.com.au>
Kevin Ryde <user42@zip.com.au>:
> Marko Rauhamaa <marko@pacujo.net> writes:
> > return length ? scm_take_str (data, length) : SCM_BOOL_F;
>
> Not sure if length==0 would be valid data, though I don't see a reason
> it wouldn't be. It might be nice to return an empty string for that.
I misread the code (and the documentation) as though 0 was the error
return value, but as you say:
> data==NULL is supposedly the error indication, perhaps that could give
> the #f.
I have fixed it:
return data ? scm_take_str (data, length) : SCM_BOOL_F;
(but not yet submitted since I'm in the middle of other changes).
> However the 1.2 code looks like it doesn't store anything to data if
> the window has been destroyed, so it might be prudent to initialize to
> NULL.
That's where I probably got the idea that 0 is the error return value --
it definitely is a bug in gdk-1.2.
I now initialize data with NULL and comment the kludge.
> It also looks like prop_type and prop_format are not set if the window
> has been destroyed, maybe they should get initial values to avoid
> problems too. GDK_NONE and 0 might be enough.
Prop_format is an integral value -- a random value is not an issue.
Prop_type is sent to sgtk_atom2scm(), which returns SCM_BOOL_F if the
atom is garbage.
So I don't think those values need to be accounted for. (If I wanted to
do it, I wouldn't rely on initializing their values, but I would rather
set them to known values after returning from
gdk_selection_property_get().
Marko
--
Marko Rauhamaa mailto:marko@pacujo.net http://pacujo.net/marko/
next prev parent reply other threads:[~2003-05-23 22:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-17 7:49 Marko Rauhamaa
2003-05-23 22:01 ` Kevin Ryde
2003-05-23 22:57 ` Marko Rauhamaa [this message]
2003-05-23 23:39 ` Kevin Ryde
2003-05-24 0:11 ` Marko Rauhamaa
2003-05-24 1:13 ` Kevin Ryde
2003-08-08 22:07 ` gdk-selection-property-get (was: Selection and DND completed) Kevin Ryde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3ptm9e0uj.fsf@lumo.pacujo.net \
--to=marko@pacujo.net \
--cc=guile-gtk@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).