public inbox for infinity@sourceware.org
 help / color / mirror / Atom feed
From: "Radovan Birdic" <Radovan.Birdic@rt-rk.com>
To: infinity@sourceware.org
Subject: Test 'valid/test-corpus' fails for 32-bit architectures
Date: Sun, 21 May 2017 20:28:00 -0000	[thread overview]
Message-ID: <7d79-5921f880-1b-16986660@154324279> (raw)

[-- Attachment #1: Type: text/plain, Size: 1861 bytes --]

Hi,

Package libi8x fails on Debian for all 32-bit endian architectures during testing:

> make  check-TESTS
> PASS: exec/ops/test-deref
> PASS: exec/test-factorial
> PASS: exec/test-smoke
> FAIL: valid/test-corpus
> ========================================
>    libi8x 0.0.3: tests/test-suite.log
> ========================================
>
> # TOTAL: 4
> # PASS:  3
> # SKIP:  0
> # XFAIL: 0
> # FAIL:  1
> # XPASS: 0
> # ERROR: 0
>
> .. contents:: :depth: 2
>
> FAIL: valid/test-corpus
> =======================
>
> corpus/i8c/0.0.4/32el/test_deref/test_deref/0015-0001[0x9]: Unhandled note
> corpus/i8c/0.0.4/32el/test_deref/test_deref/0011-0001[0x9]: Unhandled note
> corpus/i8c/0.0.4/32be/test_deref/test_deref/0015-0001[0x9]: Unhandled note
> corpus/i8c/0.0.4/32be/test_deref/test_deref/0011-0001[0x9]: Unhandled note
> valid/test-corpus.c:137: ftw_failcount == 0
> FAIL valid/test-corpus (exit status: 1)
>
> ============================================================================
> Testsuite summary for libi8x 0.0.3
> ============================================================================
> # TOTAL: 4
> # PASS:  3
> # SKIP:  0
> # XFAIL: 0
> # FAIL:  1
> # XPASS: 0
> # ERROR: 0
> ============================================================================

Full build log for mipsel:
https://buildd.debian.org/status/fetch.php?pkg=libi8x&arch=mipsel&ver=0.0.3-1&stamp=1493727519&raw=0

Binary files 'test_deref/0015-0001' and 'test_deref/0011-0001' from test folder 0.0.4 cause a problem.
Does it make sense to you to threat these tests like the same tests from 0.0.3 version?

I have created and attached a patch that handles these tests.
With this patch package builds successfully on my local mips, mipsel and i386 machines.

Could you please look at this?

Regards,
Radovan

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: fix-32-bit-arches-test-fails.patch --]
[-- Type: text/x-patch, Size: 662 bytes --]

--- libi8x-0.0.3.orig/tests/valid/test-corpus.c
+++ libi8x-0.0.3/tests/valid/test-corpus.c
@@ -77,6 +77,15 @@ do_test (struct i8x_ctx *ctx, const char
 	      || strstr (filename, "/test_deref/0015-0001") != NULL))
 	expect_err = I8X_NOTE_UNHANDLED;
     }
+  
+  if (strstr (filename, "/i8c/0.0.4/") != NULL)
+    {
+      if (__WORDSIZE == 32
+          && strstr (filename, "/i8c/0.0.4/32") != NULL
+          && (strstr (filename, "/test_deref/0011-0001") != NULL
+              || strstr (filename, "/test_deref/0015-0001") != NULL))
+        expect_err = I8X_NOTE_UNHANDLED;
+    }
 
   struct i8x_func *func;
   err = i8x_func_new_bytecode (note, &func);

             reply	other threads:[~2017-05-21 20:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-21 20:28 Radovan Birdic [this message]
2017-05-30 19:48 ` Gary Benson
2017-06-05 12:37   ` Gary Benson
2017-06-05 13:19     ` Gary Benson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7d79-5921f880-1b-16986660@154324279 \
    --to=radovan.birdic@rt-rk.com \
    --cc=infinity@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).