* Test 'valid/test-corpus' fails for 32-bit architectures
@ 2017-05-21 20:28 Radovan Birdic
2017-05-30 19:48 ` Gary Benson
0 siblings, 1 reply; 4+ messages in thread
From: Radovan Birdic @ 2017-05-21 20:28 UTC (permalink / raw)
To: infinity
[-- Attachment #1: Type: text/plain, Size: 1861 bytes --]
Hi,
Package libi8x fails on Debian for all 32-bit endian architectures during testing:
> make check-TESTS
> PASS: exec/ops/test-deref
> PASS: exec/test-factorial
> PASS: exec/test-smoke
> FAIL: valid/test-corpus
> ========================================
> libi8x 0.0.3: tests/test-suite.log
> ========================================
>
> # TOTAL: 4
> # PASS: 3
> # SKIP: 0
> # XFAIL: 0
> # FAIL: 1
> # XPASS: 0
> # ERROR: 0
>
> .. contents:: :depth: 2
>
> FAIL: valid/test-corpus
> =======================
>
> corpus/i8c/0.0.4/32el/test_deref/test_deref/0015-0001[0x9]: Unhandled note
> corpus/i8c/0.0.4/32el/test_deref/test_deref/0011-0001[0x9]: Unhandled note
> corpus/i8c/0.0.4/32be/test_deref/test_deref/0015-0001[0x9]: Unhandled note
> corpus/i8c/0.0.4/32be/test_deref/test_deref/0011-0001[0x9]: Unhandled note
> valid/test-corpus.c:137: ftw_failcount == 0
> FAIL valid/test-corpus (exit status: 1)
>
> ============================================================================
> Testsuite summary for libi8x 0.0.3
> ============================================================================
> # TOTAL: 4
> # PASS: 3
> # SKIP: 0
> # XFAIL: 0
> # FAIL: 1
> # XPASS: 0
> # ERROR: 0
> ============================================================================
Full build log for mipsel:
https://buildd.debian.org/status/fetch.php?pkg=libi8x&arch=mipsel&ver=0.0.3-1&stamp=1493727519&raw=0
Binary files 'test_deref/0015-0001' and 'test_deref/0011-0001' from test folder 0.0.4 cause a problem.
Does it make sense to you to threat these tests like the same tests from 0.0.3 version?
I have created and attached a patch that handles these tests.
With this patch package builds successfully on my local mips, mipsel and i386 machines.
Could you please look at this?
Regards,
Radovan
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: fix-32-bit-arches-test-fails.patch --]
[-- Type: text/x-patch, Size: 662 bytes --]
--- libi8x-0.0.3.orig/tests/valid/test-corpus.c
+++ libi8x-0.0.3/tests/valid/test-corpus.c
@@ -77,6 +77,15 @@ do_test (struct i8x_ctx *ctx, const char
|| strstr (filename, "/test_deref/0015-0001") != NULL))
expect_err = I8X_NOTE_UNHANDLED;
}
+
+ if (strstr (filename, "/i8c/0.0.4/") != NULL)
+ {
+ if (__WORDSIZE == 32
+ && strstr (filename, "/i8c/0.0.4/32") != NULL
+ && (strstr (filename, "/test_deref/0011-0001") != NULL
+ || strstr (filename, "/test_deref/0015-0001") != NULL))
+ expect_err = I8X_NOTE_UNHANDLED;
+ }
struct i8x_func *func;
err = i8x_func_new_bytecode (note, &func);
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Test 'valid/test-corpus' fails for 32-bit architectures
2017-05-21 20:28 Test 'valid/test-corpus' fails for 32-bit architectures Radovan Birdic
@ 2017-05-30 19:48 ` Gary Benson
2017-06-05 12:37 ` Gary Benson
0 siblings, 1 reply; 4+ messages in thread
From: Gary Benson @ 2017-05-30 19:48 UTC (permalink / raw)
To: Radovan Birdic; +Cc: infinity
Hi Radovan,
Radovan Birdic wrote:
> Package libi8x fails on Debian for all 32-bit endian architectures during testing:
...
> Full build log for mipsel:
> https://buildd.debian.org/status/fetch.php?pkg=libi8x&arch=mipsel&ver=0.0.3-1&stamp=1493727519&raw=0
>
> Binary files 'test_deref/0015-0001' and 'test_deref/0011-0001' from test folder 0.0.4 cause a problem.
> Does it make sense to you to threat these tests like the same tests from 0.0.3 version?
>
> I have created and attached a patch that handles these tests.
> With this patch package builds successfully on my local mips, mipsel and i386 machines.
>
> Could you please look at this?
I'm not around til June 6 but I don't see a problem treating the tests
like 0.0.3 for now, just to get it building. I don't remember the
details but I think it's a corner case.
Cheers,
Gary
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Test 'valid/test-corpus' fails for 32-bit architectures
2017-05-30 19:48 ` Gary Benson
@ 2017-06-05 12:37 ` Gary Benson
2017-06-05 13:19 ` Gary Benson
0 siblings, 1 reply; 4+ messages in thread
From: Gary Benson @ 2017-06-05 12:37 UTC (permalink / raw)
To: Radovan Birdic; +Cc: infinity, Matthias Klose
(Cc-ing Doko, because I think he's emailing me about the same thing)
Gary Benson wrote:
> Radovan Birdic wrote:
> > Package libi8x fails on Debian for all 32-bit endian architectures during testing:
> ...
> > Full build log for mipsel:
> > https://buildd.debian.org/status/fetch.php?pkg=libi8x&arch=mipsel&ver=0.0.3-1&stamp=1493727519&raw=0
> >
> > Binary files 'test_deref/0015-0001' and 'test_deref/0011-0001' from test folder 0.0.4 cause a problem.
> > Does it make sense to you to threat these tests like the same tests from 0.0.3 version?
> >
> > I have created and attached a patch that handles these tests.
> > With this patch package builds successfully on my local mips, mipsel and i386 machines.
> >
> > Could you please look at this?
>
> I'm not around til June 6 but I don't see a problem treating the tests
> like 0.0.3 for now, just to get it building. I don't remember the
> details but I think it's a corner case.
I've added this to the roadmap, to be looked at for the next release
(which is imminent)
https://wekan.sergiodj.net/b/kMNy6KavRQaFkRzmM/infinity/8Kpao6JKZbfjwpic2
Cheers,
Gary
--
https://infinitynotes.org/
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Test 'valid/test-corpus' fails for 32-bit architectures
2017-06-05 12:37 ` Gary Benson
@ 2017-06-05 13:19 ` Gary Benson
0 siblings, 0 replies; 4+ messages in thread
From: Gary Benson @ 2017-06-05 13:19 UTC (permalink / raw)
To: Radovan Birdic; +Cc: infinity, Matthias Klose
Gary Benson wrote:
> Gary Benson wrote:
> > Radovan Birdic wrote:
> > > Package libi8x fails on Debian for all 32-bit endian architectures during testing:
> > ...
> > > Full build log for mipsel:
> > > https://buildd.debian.org/status/fetch.php?pkg=libi8x&arch=mipsel&ver=0.0.3-1&stamp=1493727519&raw=0
> > >
> > > Binary files 'test_deref/0015-0001' and 'test_deref/0011-0001' from test folder 0.0.4 cause a problem.
> > > Does it make sense to you to threat these tests like the same tests from 0.0.3 version?
> > >
> > > I have created and attached a patch that handles these tests.
> > > With this patch package builds successfully on my local mips, mipsel and i386 machines.
> > >
> > > Could you please look at this?
> >
> > I'm not around til June 6 but I don't see a problem treating the tests
> > like 0.0.3 for now, just to get it building. I don't remember the
> > details but I think it's a corner case.
>
> I've added this to the roadmap, to be looked at for the next release
> (which is imminent)
>
> https://wekan.sergiodj.net/b/kMNy6KavRQaFkRzmM/infinity/8Kpao6JKZbfjwpic2
This commit fixes:
https://gitlab.com/gbenson/libi8x/commit/bfca3112937f902f47b4fb386f520b0ade0a3973
Cheers,
Gary
--
https://infinitynotes.org/
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-06-05 13:19 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-21 20:28 Test 'valid/test-corpus' fails for 32-bit architectures Radovan Birdic
2017-05-30 19:48 ` Gary Benson
2017-06-05 12:37 ` Gary Benson
2017-06-05 13:19 ` Gary Benson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).