insight/145: tcl error when connection to remote target times out

[craig@triscend.com]

>Number:         145
>Category:       insight
>Synopsis:       tcl error when connection to remote target times out
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    unassigned
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon May 06 14:23:00 PDT 2002
>Closed-Date:
>Last-Modified:
>Originator:     craig@triscend.com
>Release:        unknown-1.0
>Organization:
>Environment:
Windows 2000/Cygwin
>Description:
The following error is reported when the connection to a remote target times-out on windows hosts.
Error: bad option "-modal": must be -default, -icon, -message, -parent, -title, or -type
>How-To-Repeat:

>Fix:
See the attached patch file. The patch forces the use of ide_messageBox on windows hosts which fixes the problem.
>Release-Note:
>Audit-Trail:
>Unformatted:
----gnatsweb-attachment----
Content-Type: text/plain; name="interface.tcl.pat"
Content-Disposition: inline; filename="interface.tcl.pat"

Index: interface.tcl
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/library/interface.tcl,v
retrieving revision 1.43
diff -c -p -r1.43 interface.tcl
*** interface.tcl	26 Apr 2002 21:09:54 -0000	1.43
--- interface.tcl	1 May 2002 17:17:57 -0000
*************** proc set_target_name {{prompt 1}} {
*** 1074,1080 ****
  # PROC: set_target - Change the target
  # ------------------------------------------------------------------
  proc set_target {} {
!   global gdb_target_cmd gdb_target_changed gdb_pretty_name gdb_target_name
  #  debug "gdb_target_changed=$gdb_target_changed gdb_target_cmd=\"$gdb_target_cmd\""
  #  debug "gdb_target_name=$gdb_target_name"
    if {$gdb_target_cmd == "" && ![TargetSelection::native_debugging]} {
--- 1074,1080 ----
  # PROC: set_target - Change the target
  # ------------------------------------------------------------------
  proc set_target {} {
!   global gdb_target_cmd gdb_target_changed gdb_pretty_name gdb_target_name tcl_platform
  #  debug "gdb_target_changed=$gdb_target_changed gdb_target_cmd=\"$gdb_target_cmd\""
  #  debug "gdb_target_name=$gdb_target_name"
    if {$gdb_target_cmd == "" && ![TargetSelection::native_debugging]} {
*************** proc set_target {} {
*** 1109,1118 ****
        update
        set dialog_title "GDB"
        set debugger_name "GDB"
!       tk_messageBox -icon error -title $dialog_title -type ok \
! 	-modal task -message "$msg\n\n$debugger_name cannot connect to the target board\
  using [lindex $gdb_target_cmd 1].\nVerify that the board is securely connected and, if\
  necessary,\nmodify the port setting with the debugger preferences."
        return ERROR
      }
      
--- 1109,1125 ----
        update
        set dialog_title "GDB"
        set debugger_name "GDB"
!       if {$tcl_platform(platform) == "windows"} {
!           ide_messageBox [list set r] -icon error -title $dialog_title -type ok \
! 	  -modal system -message "$msg\n\n$debugger_name cannot connect to the target board\
  using [lindex $gdb_target_cmd 1].\nVerify that the board is securely connected and, if\
  necessary,\nmodify the port setting with the debugger preferences."
+         } else {
+           tk_messageBox -icon error -title $dialog_title -type ok \
+ 	  -modal system -message "$msg\n\n$debugger_name cannot connect to the target board\
+ using [lindex $gdb_target_cmd 1].\nVerify that the board is securely connected and, if\
+ necessary,\nmodify the port setting with the debugger preferences."
+         }
        return ERROR
      }