insight/151: If the control char entry in the memory window prefs is blank an error and stack trace are produced

[craig@triscend.com]

>Number:         151
>Category:       insight
>Synopsis:       If the control char entry in the memory window prefs is blank an error and stack trace are produced
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    unassigned
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue May 07 15:53:01 PDT 2002
>Closed-Date:
>Last-Modified:
>Originator:     craig@triscend.com
>Release:        unknown-1.0
>Organization:
>Environment:
Windows 2000/Cygwin & Linux
>Description:
A stack trace is displayed if the control char is removed in the memory window prefrences.
>How-To-Repeat:
After connecting to a target, open the memory window, right click on the memory window and select prefrences. Remove the dot (.) from the "Control Char" entry in the Miscellaneous section. Click Apply.
>Fix:
See attached patch, if there is no control char, the control char defaults to a dot (.)
>Release-Note:
>Audit-Trail:
>Unformatted:
----gnatsweb-attachment----
Content-Type: text/plain; name="mempref.itb.pat"
Content-Disposition: inline; filename="mempref.itb.pat"

Index: mempref.itb
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/library/mempref.itb,v
retrieving revision 1.3
diff -c -p -r1.3 mempref.itb
*** mempref.itb	5 Mar 2002 22:22:19 -0000	1.3
--- mempref.itb	7 May 2002 22:38:37 -0000
*************** body MemPref::apply {} {
*** 316,321 ****
--- 316,324 ----
        set format $gformat
      }
    }
+   if {[string length $gascii_char] <= 0} {
+     set gascii_char "."
+   }
  
    # pass all the changed values back to parent
    debug "$win configChange -size $size -numbytes $numbytes \