insight/153: Using the goto option in the memory window causes a stack trace

[craig@triscend.com]

>Number:         153
>Category:       insight
>Synopsis:       Using the goto option in the memory window causes a stack trace
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    unassigned
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed May 08 08:43:00 PDT 2002
>Closed-Date:
>Last-Modified:
>Originator:     craig@triscend.com
>Release:        unknown-1.0
>Organization:
>Environment:
Windows 2000/Cygwin & Linux, GDB for ARM
>Description:
Stack trace error when using goto within the memory window. the goto function in memwin.itb calls _update_address with the wrong number of params. It should pass 1 to the _update_address function.
>How-To-Repeat:
Connect to a target, open the memory window, right click on one of the memory locations and select goto... the stack trace is displayed.
>Fix:
The attached patch file fixes this problem, the patch also contains a fix for bug report 143.
>Release-Note:
>Audit-Trail:
>Unformatted:
----gnatsweb-attachment----
Content-Type: text/plain; name="memwin.itb.pat"
Content-Disposition: inline; filename="memwin.itb.pat"

Index: memwin.itb
===================================================================
RCS file: /cvs/src/src/gdb/gdbtk/library/memwin.itb,v
retrieving revision 1.17
diff -c -p -r1.17 memwin.itb
*** memwin.itb	6 Mar 2002 23:56:03 -0000	1.17
--- memwin.itb	8 May 2002 15:32:37 -0000
*************** body MemWin::build_win {} {
*** 116,122 ****
      $itk_interior.t configure -rowstretchmode none
    }
    scrollbar $itk_interior.sx -command [list $itk_interior.t xview] -orient horizontal
!   $itk_interior.t tag config sel -bg [$itk_interior.t cget -bg] -relief sunken
    $itk_interior.t tag config active -bg lightgray -relief sunken -wrap 0
    $itk_interior.t tag config title -bg [pref get gdb/font/header_bg] \
      -fg [pref get gdb/font/header_fg]
--- 116,123 ----
      $itk_interior.t configure -rowstretchmode none
    }
    scrollbar $itk_interior.sx -command [list $itk_interior.t xview] -orient horizontal
!   $itk_interior.t tag config sel -bg [$itk_interior.t cget -bg] \
!   -fg [$itk_interior.t cget -fg] -relief sunken
    $itk_interior.t tag config active -bg lightgray -relief sunken -wrap 0
    $itk_interior.t tag config title -bg [pref get gdb/font/header_bg] \
      -fg [pref get gdb/font/header_fg]
*************** body MemWin::goto { addr } {
*** 671,677 ****
    set current_addr $addr
    $itk_interior.f.cntl delete 0 end
    $itk_interior.f.cntl insert end $addr
!   _update_address
  }
  
  # ------------------------------------------------------------------
--- 672,678 ----
    set current_addr $addr
    $itk_interior.f.cntl delete 0 end
    $itk_interior.f.cntl insert end $addr
!   _update_address 1
  }
  
  # ------------------------------------------------------------------